New bigint implementation in the vm.

runtime/lib/integers.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
-#include "vm/bigint_operations.h"
 #include "vm/dart_entry.h"
 #include "vm/dart_api_impl.h"
 #include "vm/exceptions.h"
 #include "vm/isolate.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, trace_intrinsified_natives, false,
     "Report if any of the intrinsified natives are called");
 
 // Smi natives.
 
 // Returns false if integer is in wrong representation, e.g., as is a Bigint
 // when it could have been a Smi.
 static bool CheckInteger(const Integer& i) {
   if (i.IsBigint()) {
     const Bigint& bigint = Bigint::Cast(i);
-    return !BigintOperations::FitsIntoSmi(bigint) &&
-        !BigintOperations::FitsIntoInt64(bigint);
+    return !bigint.FitsIntoSmi() && !bigint.FitsIntoInt64();
   }
   if (i.IsMint()) {
     const Mint& mint = Mint::Cast(i);
     return !Smi::IsValid(mint.value());
   }
   return true;
 }
 
 
 static int BitLengthInt64(int64_t value) {
   value ^= value >> (8 * sizeof(value) - 1);  // flip bits if negative.
+  // TODO(regis): Utils::HighestBit handles negative values. Why the above?
   return value == 0 ? 0 : Utils::HighestBit(value) + 1;
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_bitAndFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_bitAndFromInteger %s & %s\n",
         right.ToCString(), left.ToCString());
   }
   const Integer& result =
       Integer::Handle(left.BitOp(Token::kBIT_AND, right));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();

[srdjan, 2014/09/08 19:19:49]

maybe: result.IsNull() ? result.raw() : result.AsValidInteger(); ?

You could add a comment to all relevant methods that they return  null if a
bigint operation is required.

[regis, 2014/09/09 19:18:14]

Done.

 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_bitOrFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_bitOrFromInteger %s | %s\n",
         left.ToCString(), right.ToCString());
   }
   const Integer& result =
       Integer::Handle(left.BitOp(Token::kBIT_OR, right));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_bitXorFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_bitXorFromInteger %s ^ %s\n",
         left.ToCString(), right.ToCString());
   }
   const Integer& result =
       Integer::Handle(left.BitOp(Token::kBIT_XOR, right));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_addFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left_int, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_addFromInteger %s + %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   const Integer& result =
       Integer::Handle(left_int.ArithmeticOp(Token::kADD, right_int));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_subFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left_int, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_subFromInteger %s - %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   const Integer& result =
       Integer::Handle(left_int.ArithmeticOp(Token::kSUB, right_int));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_mulFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left_int, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_mulFromInteger %s * %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   const Integer& result =
       Integer::Handle(left_int.ArithmeticOp(Token::kMUL, right_int));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_truncDivFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left_int, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   ASSERT(!right_int.IsZero());
   const Integer& result =
       Integer::Handle(left_int.ArithmeticOp(Token::kTRUNCDIV, right_int));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_moduloFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left_int, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(right_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_moduloFromInteger %s mod %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   if (right_int.IsZero()) {
     // Should have been caught before calling into runtime.
     UNIMPLEMENTED();
   }
   const Integer& result =
       Integer::Handle(left_int.ArithmeticOp(Token::kMOD, right_int));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_greaterThanFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
@@ skipping 97 matching lines @@
                                         const Integer& value,
                                         const Smi& amount,
                                         const bool silent = false) {
   if (amount.Value() < 0) {
     Exceptions::ThrowArgumentError(amount);
   }
   if (value.IsSmi()) {
     const Smi& smi_value = Smi::Cast(value);
     return smi_value.ShiftOp(kind, amount, silent);
   }
-  Bigint& big_value = Bigint::Handle();
   if (value.IsMint()) {
     const int64_t mint_value = value.AsInt64Value();
     const int count = Utils::HighestBit(mint_value);
     intptr_t shift_count = amount.Value();
     if (kind == Token::kSHR) {
       shift_count = -shift_count;
     }
     if ((count + shift_count) < Mint::kBits) {
       switch (kind) {
         case Token::kSHL:
           return Integer::New(mint_value << shift_count, Heap::kNew, silent);
         case Token::kSHR:
           return Integer::New(mint_value >> -shift_count, Heap::kNew, silent);
         default:
           UNIMPLEMENTED();
       }
     } else {
       // Overflow in shift, use Bigints
-      big_value = BigintOperations::NewFromInt64(mint_value);
+      return Integer::null();
     }
   } else {
     ASSERT(value.IsBigint());
-    big_value = Bigint::Cast(value).raw();
-  }
-  switch (kind) {
-    case Token::kSHL:
-      return BigintOperations::ShiftLeft(big_value, amount.Value());
-    case Token::kSHR:
-      return BigintOperations::ShiftRight(big_value, amount.Value());
-    default:
-      UNIMPLEMENTED();
   }
   return Integer::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_leftShiftWithMask32, 3) {
   const Integer& value = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, shift_count, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, mask, arguments->NativeArgAt(2));
   ASSERT(CheckInteger(value));
@@ skipping 14 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(Smi_shrFromInt, 2) {
   const Smi& amount = Smi::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, value, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(amount));
   ASSERT(CheckInteger(value));
   const Integer& result = Integer::Handle(
       ShiftOperationHelper(Token::kSHR, value, amount));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 
 DEFINE_NATIVE_ENTRY(Smi_shlFromInt, 2) {
   const Smi& amount = Smi::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, value, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(amount));
   ASSERT(CheckInteger(value));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Smi_shlFromInt: %s << %s\n",
         value.ToCString(), amount.ToCString());
   }
   const Integer& result = Integer::Handle(
       ShiftOperationHelper(Token::kSHL, value, amount));
+  if (result.IsNull()) {
+    return result.raw();  // A bigint operation is required.
+  }
   return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(Smi_bitNegate, 1) {
   const Smi& operand = Smi::CheckedHandle(arguments->NativeArgAt(0));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Smi_bitNegate: %s\n", operand.ToCString());
   }
   intptr_t result = ~operand.Value();
@@ skipping 43 matching lines @@
 DEFINE_NATIVE_ENTRY(Mint_shlFromInt, 2) {
   // Use the preallocated out of memory exception to avoid calling
   // into dart code or allocating any code.
   const Instance& exception =
       Instance::Handle(isolate->object_store()->out_of_memory());
   Exceptions::Throw(isolate, exception);
   UNREACHABLE();
   return 0;
 }
 
-
 // Bigint natives.
 
-DEFINE_NATIVE_ENTRY(Bigint_bitNegate, 1) {
-  const Bigint& value = Bigint::CheckedHandle(arguments->NativeArgAt(0));
-  const Bigint& result = Bigint::Handle(BigintOperations::BitNot(value));
-  ASSERT(CheckInteger(value));
-  ASSERT(CheckInteger(result));
-  return result.AsValidInteger();
+DEFINE_NATIVE_ENTRY(Bigint_getNeg, 1) {
+  const Bigint& bigint = Bigint::CheckedHandle(arguments->NativeArgAt(0));
+  return bigint.neg();
 }
 
 
-DEFINE_NATIVE_ENTRY(Bigint_bitLength, 1) {
-  const Bigint& value = Bigint::CheckedHandle(arguments->NativeArgAt(0));
-  return Integer::New(BigintOperations::BitLength(value));
+DEFINE_NATIVE_ENTRY(Bigint_setNeg, 2) {
+  const Bigint& bigint = Bigint::CheckedHandle(arguments->NativeArgAt(0));
+  const Bool& neg = Bool::CheckedHandle(arguments->NativeArgAt(1));
+  bigint.set_neg(neg);
+  return Object::null();
 }
 
 
-DEFINE_NATIVE_ENTRY(Bigint_shlFromInt, 2) {
-  // Use the preallocated out of memory exception to avoid calling
-  // into dart code or allocating any code.
-  const Instance& exception =
-      Instance::Handle(isolate->object_store()->out_of_memory());
-  Exceptions::Throw(isolate, exception);
-  UNREACHABLE();
-  return 0;
+DEFINE_NATIVE_ENTRY(Bigint_getUsed, 1) {
+  const Bigint& bigint = Bigint::CheckedHandle(arguments->NativeArgAt(0));
+  return bigint.used();
+}
+
+
+DEFINE_NATIVE_ENTRY(Bigint_setUsed, 2) {
+  const Bigint& bigint = Bigint::CheckedHandle(arguments->NativeArgAt(0));
+  const Smi& used = Smi::CheckedHandle(arguments->NativeArgAt(1));
+  bigint.set_used(used);
+  return Object::null();
+}
+
+
+DEFINE_NATIVE_ENTRY(Bigint_getDigits, 1) {
+  const Bigint& bigint = Bigint::CheckedHandle(arguments->NativeArgAt(0));
+  return bigint.digits();
+}
+
+
+DEFINE_NATIVE_ENTRY(Bigint_setDigits, 2) {
+  const Bigint& bigint = Bigint::CheckedHandle(arguments->NativeArgAt(0));
+  const TypedData& digits = TypedData::CheckedHandle(arguments->NativeArgAt(1));
+  bigint.set_digits(digits);
+  return Object::null();
+}
+
+
+DEFINE_NATIVE_ENTRY(Bigint_allocate, 1) {

[srdjan, 2014/09/08 19:19:49]

Why one argument? type?

[regis, 2014/09/09 19:18:14]

This is the null type arguments, since class Bigint is not parameterized. Added
comment.

+  return Bigint::New();
 }
 
 }  // namespace dart