New bigint implementation in the vm.

runtime/lib/typed_data.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
 
-#include "vm/bigint_operations.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
 namespace dart {
 
 // TypedData.
 
 // Checks to see if offsetInBytes + num_bytes is in the range.
 static void RangeCheck(intptr_t offset_in_bytes,
@@ skipping 253 matching lines @@
     const String& error = String::Handle(String::NewFormatted(                 \
         "Expected a TypedData object but found %s", instance.ToCString()));    \
     Exceptions::ThrowArgumentError(error);                                     \
   }                                                                            \
   return Integer::NewFromUint64(value);                                        \
 }                                                                              \
 
 
 // TODO(asiva): Consider truncating the bigint value if it does not fit into
 // a uint64_t value (see ASSERT(BigintOperations::FitsIntoUint64(bigint))).
+// TODO(regis): Shouldn't we throw an argument error if the bigint is too large
+// instead of assert faulting or truncating the bigint as suggested?
 #define TYPED_DATA_UINT64_SETTER(setter, object)                               \
 DEFINE_NATIVE_ENTRY(TypedData_##setter, 3) {                                   \
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, instance, arguments->NativeArgAt(0)); \
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, offsetInBytes, arguments->NativeArgAt(1)); \
   GET_NON_NULL_NATIVE_ARGUMENT(object, value, arguments->NativeArgAt(2));      \
   uint64_t object_value;                                                       \
   if (value.IsBigint()) {                                                      \
     const Bigint& bigint = Bigint::Cast(value);                                \
-    ASSERT(BigintOperations::FitsIntoUint64(bigint));                          \
-    object_value = BigintOperations::AbsToUint64(bigint);                      \
+    ASSERT(bigint.FitsIntoUint64());                                           \
+    object_value = bigint.AsUint64Value();                                     \
   } else {                                                                     \
     ASSERT(value.IsMint() || value.IsSmi());                                   \
     object_value = value.AsInt64Value();                                       \
   }                                                                            \
   if (instance.IsTypedData()) {                                                \
     const TypedData& array = TypedData::Cast(instance);                        \
     RangeCheck(offsetInBytes.Value(), 8, array.LengthInBytes(), 8);            \
     array.setter(offsetInBytes.Value(), object_value);                         \
   } else if (instance.IsExternalTypedData()) {                                 \
     const ExternalTypedData& array = ExternalTypedData::Cast(instance);        \
@@ skipping 105 matching lines @@
   return Integer::New(value);
 }
 
 
 DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint64, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
   uint64_t value;
   if (host_value.IsBigint()) {
     const Bigint& bigint = Bigint::Cast(host_value);
-    ASSERT(BigintOperations::FitsIntoUint64(bigint));
-    value = BigintOperations::AbsToUint64(bigint);
+    ASSERT(bigint.FitsIntoUint64());
+    value = bigint.AsUint64Value();
   } else {
     ASSERT(host_value.IsMint() || host_value.IsSmi());
     value = host_value.AsInt64Value();
   }
   if (little_endian.value()) {
     value = Utils::HostToLittleEndian64(value);
   } else {
     value = Utils::HostToBigEndian64(value);
   }
   return Integer::NewFromUint64(value);
@@ skipping 23 matching lines @@
     value = bit_cast<double>(
         Utils::HostToLittleEndian64(bit_cast<uint64_t>(value)));
   } else {
     value = bit_cast<double>(
         Utils::HostToBigEndian64(bit_cast<uint64_t>(value)));
   }
   return Double::New(value);
 }
 
 }  // namespace dart