Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: net/socket/unix_domain_client_socket_posix.h

Issue 509133002: Raw SocketDescriptor variant of UnixDomainServerSocket::Accept (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits; waiting on mmenke for broader comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/unix_domain_client_socket_posix.h
diff --git a/net/socket/unix_domain_client_socket_posix.h b/net/socket/unix_domain_client_socket_posix.h
index 81f2bdfbef5a88da3197e62f917756ea9a254037..ab5a4664876e6ef2a90fa994610ae3c9d8b42e7c 100644
--- a/net/socket/unix_domain_client_socket_posix.h
+++ b/net/socket/unix_domain_client_socket_posix.h
@@ -13,6 +13,7 @@
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
#include "net/base/net_log.h"
+#include "net/socket/socket_descriptor.h"
#include "net/socket/stream_socket.h"
namespace net {
@@ -63,6 +64,11 @@ class NET_EXPORT UnixDomainClientSocket : public StreamSocket {
virtual int SetReceiveBufferSize(int32 size) OVERRIDE;
virtual int SetSendBufferSize(int32 size) OVERRIDE;
+ // Releases ownership of underlying SocketDescriptor to caller.
+ // Internal state is reset so that this object can be used again.
+ // Returns kInvalidSocket if this object is not connected.
mmenke 2014/09/03 14:56:46 This isn't true. A listening socket isn't connect
Chris Masone 2014/09/03 15:57:11 The code will now DCHECK if the underlying SocketL
+ SocketDescriptor ReleaseSocketDescriptor();
+
private:
const std::string socket_path_;
const bool use_abstract_namespace_;

Powered by Google App Engine
This is Rietveld 408576698