net/socket/unix_domain_client_socket_posix.cc - Issue 509133002: Raw SocketDescriptor variant of UnixDomainServerSocket::Accept

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/socket/unix_domain_client_socket_posix.cc

Issue 509133002: Raw SocketDescriptor variant of UnixDomainServerSocket::Accept (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ReleaseSocketDescriptor to UnixDomainClientSocket class Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« net/socket/unix_domain_client_socket_posix.h ('K') | « net/socket/unix_domain_client_socket_posix.h ('k') | net/socket/unix_domain_client_socket_posix_unittest.cc » ('j') | net/socket/unix_domain_server_socket_posix.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/socket/unix_domain_client_socket_posix.h"	5 #include "net/socket/unix_domain_client_socket_posix.h"

6	6

7 #include <sys/socket.h>	7 #include <sys/socket.h>

8 #include <sys/un.h>	8 #include <sys/un.h>

9	9

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 141 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
152 int UnixDomainClientSocket::SetReceiveBufferSize(int32 size) {	152 int UnixDomainClientSocket::SetReceiveBufferSize(int32 size) {

153 NOTIMPLEMENTED();	153 NOTIMPLEMENTED();

154 return ERR_NOT_IMPLEMENTED;	154 return ERR_NOT_IMPLEMENTED;

155 }	155 }

156	156

157 int UnixDomainClientSocket::SetSendBufferSize(int32 size) {	157 int UnixDomainClientSocket::SetSendBufferSize(int32 size) {

158 NOTIMPLEMENTED();	158 NOTIMPLEMENTED();

159 return ERR_NOT_IMPLEMENTED;	159 return ERR_NOT_IMPLEMENTED;

160 }	160 }

161	161

	162 SocketDescriptor UnixDomainClientSocket::ReleaseSocketDescriptor() {

	163 if (socket_) {
	byungchul 2014/09/03 00:13:54 Fast return if !socket_ Fast return if !socket_ Chris Masone 2014/09/03 02:38:39 Done. Show quoted text On 2014/09/03 00:13:54, byungchul wrote: > Fast return if !socket_ Done.
	164 SocketDescriptor socket_fd = socket_->ReleaseConnectedSocket();

	165 socket_.reset();

	166 return socket_fd;

	167 }

	168 return kInvalidSocket;

	169 }

	170

162 } // namespace net	171 } // namespace net

OLD	NEW