Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 509123003: Put thunk targets directly into loadable modules in static build (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, DaveMoore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Put thunk targets directly into loadable modules in static build gles2_thunks.cc, gles2_impl_thunks.cc, etc define symbols that should be exported from loadable modules. If these files are linked into a static library and that static library is then linked into a loadable module, the linker may or may not pull in the object files for the thunks depending on if any symbols from that object file are referenced by some other object file in the component. This puts the thunks into a gypi that can be included directly into a loadable module so the object files containing the thunks are on the link line directly and make it into the final library. R=erg@chromium.org Committed: https://crrev.com/66d1d784036d8b7ab4889c46d0bdb87a9a264a9f Cr-Commit-Position: refs/heads/master@{#292315}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -61 lines) Patch
M mojo/mojo.gyp View 2 chunks +6 lines, -2 lines 0 comments Download
M mojo/mojo_apps.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 8 chunks +24 lines, -8 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
A mojo/mojo_public_gles2_for_loadable_module.gypi View 1 chunk +59 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 1 chunk +3 lines, -1 line 0 comments Download
M mojo/mojo_variables.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jamesr
This fixes the thunk symbol missing error. GN uses source_sets so it doesn't have this ...
6 years, 3 months ago (2014-08-27 19:04:40 UTC) #1
jamesr
It's probably worth doing this for the system thunks as well, but that seems less ...
6 years, 3 months ago (2014-08-27 19:05:53 UTC) #2
DaveMoore
davemoore@chromium.org changed reviewers: + davemoore@chromium.org
6 years, 3 months ago (2014-08-27 19:08:19 UTC) #3
DaveMoore
lgtm
6 years, 3 months ago (2014-08-27 19:08:19 UTC) #4
Elliot Glaysher
lgtm
6 years, 3 months ago (2014-08-27 19:09:51 UTC) #5
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 3 months ago (2014-08-27 19:35:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/509123003/1
6 years, 3 months ago (2014-08-27 19:36:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 20:45:41 UTC) #8
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 20:45:42 UTC) #9
jamesr
On 2014/08/27 20:45:42, I haz the power (commit-bot) wrote: > Failed to commit the patch. ...
6 years, 3 months ago (2014-08-27 20:55:18 UTC) #10
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 3 months ago (2014-08-27 20:56:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/509123003/20001
6 years, 3 months ago (2014-08-27 20:57:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as bbed8a31a36c3449799a77fbca85bfe86c4564c8
6 years, 3 months ago (2014-08-28 03:55:50 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:20 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66d1d784036d8b7ab4889c46d0bdb87a9a264a9f
Cr-Commit-Position: refs/heads/master@{#292315}

Powered by Google App Engine
This is Rietveld 408576698