Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 509103002: Add directory for Chromecast media related components. (Closed)

Created:
6 years, 3 months ago by damienv1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add directory for Chromecast media related components. BUG=408189 Committed: https://crrev.com/da03461bff02d90dd49890435626c97b044bd22a Cr-Commit-Position: refs/heads/master@{#292241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
A + chromecast/media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
damienv1
damienv@chromium.org changed reviewers: + gunsch@chromium.org, lcwu@chromium.org, scherkus@chromium.org
6 years, 3 months ago (2014-08-27 18:11:43 UTC) #1
damienv1
Please take a look. Thanks.
6 years, 3 months ago (2014-08-27 20:12:35 UTC) #2
lcwu1
lgtm
6 years, 3 months ago (2014-08-27 20:19:44 UTC) #3
xhwang
xhwang@chromium.org changed reviewers: + xhwang@chromium.org
6 years, 3 months ago (2014-08-27 20:23:08 UTC) #4
xhwang
drive-by: lgtm, but can you update the CL title to reflect what you actually do ...
6 years, 3 months ago (2014-08-27 20:23:08 UTC) #5
lcwu1
On 2014/08/27 20:23:08, xhwang wrote: > drive-by: lgtm, but can you update the CL title ...
6 years, 3 months ago (2014-08-27 20:28:33 UTC) #6
damienv1
xhwang@ I didn't remove any dependency: it is not the same file. It's the chromium ...
6 years, 3 months ago (2014-08-27 20:30:06 UTC) #7
xhwang
On 2014/08/27 20:28:33, lcwu1 wrote: > On 2014/08/27 20:23:08, xhwang wrote: > > drive-by: lgtm, ...
6 years, 3 months ago (2014-08-27 20:30:13 UTC) #8
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 3 months ago (2014-08-27 20:48:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/509103002/1
6 years, 3 months ago (2014-08-27 20:50:25 UTC) #10
damienv1
The CQ bit was unchecked by damienv@chromium.org
6 years, 3 months ago (2014-08-27 20:56:33 UTC) #11
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 3 months ago (2014-08-27 22:06:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/509103002/1
6 years, 3 months ago (2014-08-27 22:07:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as d2c5b0da43c4742aae5177e8a6b2b27e67c6b780
6 years, 3 months ago (2014-08-27 22:09:25 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da03461bff02d90dd49890435626c97b044bd22a
Cr-Commit-Position: refs/heads/master@{#292241}

Powered by Google App Engine
This is Rietveld 408576698