Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: ui/gfx/platform_font_pango.h

Issue 509093004: linux: Make RenderTextPango avoid clipping underlines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/platform_font_pango.cc » ('j') | ui/gfx/render_text_pango.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/platform_font_pango.h
diff --git a/ui/gfx/platform_font_pango.h b/ui/gfx/platform_font_pango.h
index 3a494389c139a51babb39da06cc2a92b3b808008..a636db271c460caaba7933dea8345386341b4db3 100644
--- a/ui/gfx/platform_font_pango.h
+++ b/ui/gfx/platform_font_pango.h
@@ -40,13 +40,6 @@ class GFX_EXPORT PlatformFontPango : public PlatformFont {
static void SetDefaultFontDescription(const std::string& font_description);
#endif
- // Position as an offset from the height of the drawn text, used to draw
- // an underline. This is a negative number, so the underline would be
- // drawn at y + height + underline_position.
- double underline_position() const;
- // The thickness to draw the underline.
- double underline_thickness() const;
-
// Overridden from PlatformFont:
virtual Font DeriveFont(int size_delta, int style) const OVERRIDE;
virtual int GetHeight() const OVERRIDE;
@@ -82,7 +75,7 @@ class GFX_EXPORT PlatformFontPango : public PlatformFont {
// Initializes this object as a copy of another PlatformFontPango.
void InitFromPlatformFont(const PlatformFontPango* other);
- // Potentially slow call to get pango metrics (average width, underline info).
+ // Potentially slow call to get pango metrics (average width).
void InitPangoMetrics();
// Setup a Skia context to use the current typeface.
@@ -114,8 +107,6 @@ class GFX_EXPORT PlatformFontPango : public PlatformFont {
// to compute them.
bool pango_metrics_inited_;
double average_width_pixels_;
- double underline_position_pixels_;
- double underline_thickness_pixels_;
// The default font, used for the default constructor.
static Font* default_font_;
« no previous file with comments | « no previous file | ui/gfx/platform_font_pango.cc » ('j') | ui/gfx/render_text_pango.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698