Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 50903003: Add Platform::physicalMemoryInBytes to WebKitPlatformSupportImpl. (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@physicalmemory_renderer
Visibility:
Public.

Description

Add Platform::physicalMemoryInBytes to WebKitPlatformSupportImpl. BUG=312241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233005

Patch Set 1 #

Patch Set 2 : Change result to MB #

Patch Set 3 : return type to size_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webkit/child/webkitplatformsupport_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/child/webkitplatformsupport_impl.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
rmcilroy
7 years, 1 month ago (2013-10-29 17:24:05 UTC) #1
jochen (gone - plz use gerrit)
lgtm (but i'm not an owner)
7 years, 1 month ago (2013-10-30 15:22:21 UTC) #2
rmcilroy
jamesr@chromium.org: Please review this change.
7 years, 1 month ago (2013-10-30 15:37:32 UTC) #3
jamesr
have you tested that this works inside the sandbox on all platforms?
7 years, 1 month ago (2013-10-30 19:51:01 UTC) #4
jamesr
All of the callers I can find today are either android-specific or in browser-specific code, ...
7 years, 1 month ago (2013-10-30 19:52:11 UTC) #5
rmcilroy
On 2013/10/30 19:52:11, jamesr wrote: > All of the callers I can find today are ...
7 years, 1 month ago (2013-10-31 14:50:42 UTC) #6
jamesr
Ping this patch again when the dependency has landed.
7 years, 1 month ago (2013-11-01 19:53:39 UTC) #7
rmcilroy
On 2013/11/01 19:53:39, jamesr wrote: > Ping this patch again when the dependency has landed. ...
7 years, 1 month ago (2013-11-04 22:34:03 UTC) #8
jamesr
lgtm, thanks
7 years, 1 month ago (2013-11-04 22:37:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/50903003/60001
7 years, 1 month ago (2013-11-05 09:58:55 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 11:02:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/50903003/60001
7 years, 1 month ago (2013-11-05 13:17:11 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219584
7 years, 1 month ago (2013-11-05 14:26:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/50903003/60001
7 years, 1 month ago (2013-11-05 14:29:24 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 16:58:50 UTC) #15
Message was sent while issue was closed.
Change committed as 233005

Powered by Google App Engine
This is Rietveld 408576698