|
|
Description[Android] Test IME and select action bar behavior after cut
Ime should not be dismissed and Select action bar should be dismissed in
case a cut operation is performed on any input field. Add test case
to check this.
Committed: https://crrev.com/b496b15650ba38a5b313ff6432fe8b5512d25d7d
Cr-Commit-Position: refs/heads/master@{#292408}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removed unwanted call to selectall #
Total comments: 3
Messages
Total messages: 12 (0 generated)
ankit2.kumar@samsung.com changed reviewers: + aurimas@chromium.org, jdduke@chromium.org
PTAL
https://codereview.chromium.org/508993002/diff/1/content/public/android/javat... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/1/content/public/android/javat... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:172: selectAll(mImeAdapter); Is this |selectAll()| call necessary? Isn't long pressing supposed to select the text?
@jdduke PTAL new patch https://codereview.chromium.org/508993002/diff/1/content/public/android/javat... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/1/content/public/android/javat... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:172: selectAll(mImeAdapter); On 2014/08/27 14:53:12, jdduke wrote: > Is this |selectAll()| call necessary? Isn't long pressing supposed to select the > text? Done. Long pressing is sufficient to select the text. Removing |selectAll()| call.
lgtm with nit. https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:167: waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, Nit: This can all fit on a single line (Java style is 100 character width).
PTAL https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:167: waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, On 2014/08/28 14:59:08, jdduke wrote: > Nit: This can all fit on a single line (Java style is 100 character width). @jdduke Line width is 101 character. While submitting due to presubmit warning I added a line break. Please suggest if it is fine to make it fit on a single line.
lgtm https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:167: waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, On 2014/08/28 15:31:09, ankit wrote: > On 2014/08/28 14:59:08, jdduke wrote: > > Nit: This can all fit on a single line (Java style is 100 character width). > @jdduke > Line width is 101 character. While submitting due to presubmit warning I added a > line break. > Please suggest if it is fine to make it fit on a single line. Ah, right, I didn't include the indent.
On 2014/08/28 15:33:22, jdduke wrote: > lgtm > > https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... > File > content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java > (right): > > https://codereview.chromium.org/508993002/diff/20001/content/public/android/j... > content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:167: > waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, > On 2014/08/28 15:31:09, ankit wrote: > > On 2014/08/28 14:59:08, jdduke wrote: > > > Nit: This can all fit on a single line (Java style is 100 character width). > > @jdduke > > Line width is 101 character. While submitting due to presubmit warning I added > a > > line break. > > Please suggest if it is fine to make it fit on a single line. > > Ah, right, I didn't include the indent. Thanks.
The CQ bit was checked by ankit2.kumar@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/508993002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 01d6972e67e478528ba42ad2ad864c13d09a16e2
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b496b15650ba38a5b313ff6432fe8b5512d25d7d Cr-Commit-Position: refs/heads/master@{#292408} |