Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 508993002: Added test case for ime and select action bar check in case of cut operation. (Closed)

Created:
6 years, 3 months ago by ankit
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Test IME and select action bar behavior after cut Ime should not be dismissed and Select action bar should be dismissed in case a cut operation is performed on any input field. Add test case to check this. Committed: https://crrev.com/b496b15650ba38a5b313ff6432fe8b5512d25d7d Cr-Commit-Position: refs/heads/master@{#292408}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unwanted call to selectall #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 1 chunk +14 lines, -1 line 3 comments Download

Messages

Total messages: 12 (0 generated)
ankit
ankit2.kumar@samsung.com changed reviewers: + aurimas@chromium.org, jdduke@chromium.org
6 years, 3 months ago (2014-08-27 14:32:36 UTC) #1
ankit
PTAL
6 years, 3 months ago (2014-08-27 14:32:36 UTC) #2
jdduke (slow)
https://codereview.chromium.org/508993002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode172 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:172: selectAll(mImeAdapter); Is this |selectAll()| call necessary? Isn't long pressing ...
6 years, 3 months ago (2014-08-27 14:53:12 UTC) #3
ankit
@jdduke PTAL new patch https://codereview.chromium.org/508993002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode172 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:172: selectAll(mImeAdapter); On 2014/08/27 14:53:12, jdduke ...
6 years, 3 months ago (2014-08-28 06:30:17 UTC) #4
jdduke (slow)
lgtm with nit. https://codereview.chromium.org/508993002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode167 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:167: waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, Nit: This can all ...
6 years, 3 months ago (2014-08-28 14:59:08 UTC) #5
ankit
PTAL https://codereview.chromium.org/508993002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode167 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:167: waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, On 2014/08/28 14:59:08, jdduke wrote: > ...
6 years, 3 months ago (2014-08-28 15:31:09 UTC) #6
jdduke (slow)
lgtm https://codereview.chromium.org/508993002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/508993002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode167 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:167: waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, On 2014/08/28 15:31:09, ankit wrote: > ...
6 years, 3 months ago (2014-08-28 15:33:22 UTC) #7
ankit
On 2014/08/28 15:33:22, jdduke wrote: > lgtm > > https://codereview.chromium.org/508993002/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java > File > content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java > ...
6 years, 3 months ago (2014-08-28 15:46:24 UTC) #8
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 3 months ago (2014-08-28 15:47:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/508993002/20001
6 years, 3 months ago (2014-08-28 15:47:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 01d6972e67e478528ba42ad2ad864c13d09a16e2
6 years, 3 months ago (2014-08-28 17:10:43 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b496b15650ba38a5b313ff6432fe8b5512d25d7d
Cr-Commit-Position: refs/heads/master@{#292408}

Powered by Google App Engine
This is Rietveld 408576698