DevTools: Protocol handler generator for content

content/browser/devtools/render_view_devtools_agent_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
 #define CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/devtools/ipc_devtools_agent_host.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/web_contents_observer.h"
 
 namespace cc {
 class CompositorFrameMetadata;
 }
 
 namespace content {
 
 class DevToolsPowerHandler;
+class DevToolsProtocolHandlerImpl;
 class DevToolsTracingHandler;
 class RendererOverridesHandler;
 class RenderViewHost;
 class RenderViewHostImpl;
 
 #if defined(OS_ANDROID)
 class PowerSaveBlockerImpl;
 #endif
 
+namespace devtools {
+
+namespace input {
+class InputHandler;

[dgozman, 2014/09/22 12:46:06]

Let's include them all.

[vkuzkokov, 2014/09/22 12:57:28]

Done.

+}  // namespace input
+
+namespace page {
+class PageHandler;
+}  // namespace page
+
+}  // namespace devtools
+
 class CONTENT_EXPORT RenderViewDevToolsAgentHost
     : public IPCDevToolsAgentHost,
       private WebContentsObserver,
       public NotificationObserver {
  public:
   static void OnCancelPendingNavigation(RenderViewHost* pending,
                                         RenderViewHost* current);
 
   RenderViewDevToolsAgentHost(RenderViewHost*);
 
@@ skipping 52 matching lines @@
 
   void OnDispatchOnInspectorFrontend(const std::string& message);
   void OnSaveAgentRuntimeState(const std::string& state);
 
   void ClientDetachedFromRenderer();
 
   void InnerOnClientAttached();
   void InnerClientDetachedFromRenderer();
 
   RenderViewHostImpl* render_view_host_;
+  scoped_ptr<DevToolsProtocolHandlerImpl> handler_impl_;

[dgozman, 2014/09/22 12:46:06]

Let's put this after all handlers for safe destruction order.

[vkuzkokov, 2014/09/22 12:57:28]

Done.

+  scoped_ptr<devtools::input::InputHandler> input_handler_;
+  scoped_ptr<devtools::page::PageHandler> page_handler_;
   scoped_ptr<RendererOverridesHandler> overrides_handler_;
   scoped_ptr<DevToolsTracingHandler> tracing_handler_;
   scoped_ptr<DevToolsPowerHandler> power_handler_;
 #if defined(OS_ANDROID)
   scoped_ptr<PowerSaveBlockerImpl> power_save_blocker_;
 #endif
   std::string state_;
   NotificationRegistrar registrar_;
   bool reattaching_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewDevToolsAgentHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_