Rewrote multicol/newmulticol/column-rules-fixed-height and moved it to fast/multicol/

Rewrote multicol/newmulticol/column-rules-fixed-height and moved it to fast/multicol/

It's a pure reftest now. It used to compare between the old and new
implementations, until settings.setRegionBasedColumnsEnabled(true)
got removed from a lot of tests a couple of months ago, at which point
the test and the ref essentially became identical.

R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181248

[Julien - ping for review, 2014-09-02 15:05:13]

the new tests looks fairly different from the old one (no padding or border on
the multi-column container) but I assume that's because this was not what the
test is looking for (based on the name).

lgtm, but we should try to remove more CSS rules as the test seems more
complicated now.

https://codereview.chromium.org/508953004/diff/1/LayoutTests/fast/multicol/co...
File LayoutTests/fast/multicol/column-rules-fixed-height.html (right):

https://codereview.chromium.org/508953004/diff/1/LayoutTests/fast/multicol/co...
LayoutTests/fast/multicol/column-rules-fixed-height.html:4: <div
style="-webkit-columns:3; -webkit-column-rule:5px solid blue;
-webkit-column-gap:5px; columns:3; column-rule:4px solid blue; column-gap:5px;
width:310px; height:315px; line-height:50px;">
It think -webkit-column-rule and column-rule rules should be the same (right now
it's 4px vs 5px width)

[mstensho (USE GERRIT), 2014-09-02 16:56:47]

On 2014/09/02 15:05:13, Julien Chaffraix - PST wrote:
> the new tests looks fairly different from the old one (no padding or border on
> the multi-column container) but I assume that's because this was not what the
> test is looking for (based on the name).

Correct.

> lgtm, but we should try to remove more CSS rules as the test seems more
> complicated now.

Not sure if I understand what you mean.

[mstensho (USE GERRIT), 2014-09-02 16:56:58]

https://codereview.chromium.org/508953004/diff/1/LayoutTests/fast/multicol/co...
File LayoutTests/fast/multicol/column-rules-fixed-height.html (right):

https://codereview.chromium.org/508953004/diff/1/LayoutTests/fast/multicol/co...
LayoutTests/fast/multicol/column-rules-fixed-height.html:4: <div
style="-webkit-columns:3; -webkit-column-rule:5px solid blue;
-webkit-column-gap:5px; columns:3; column-rule:4px solid blue; column-gap:5px;
width:310px; height:315px; line-height:50px;">
On 2014/09/02 15:05:13, Julien Chaffraix - PST wrote:
> It think -webkit-column-rule and column-rule rules should be the same (right
now
> it's 4px vs 5px width)

Doh! Definitely! Done.

[Julien - ping for review, 2014-09-02 17:03:06]

On 2014/09/02 at 16:56:47, mstensho wrote:
> On 2014/09/02 15:05:13, Julien Chaffraix - PST wrote:
> > the new tests looks fairly different from the old one (no padding or border
on
> > the multi-column container) but I assume that's because this was not what
the
> > test is looking for (based on the name).
> 
> Correct.
> 
> > lgtm, but we should try to remove more CSS rules as the test seems more
> > complicated now.
> 
> Not sure if I understand what you mean.

The new test has a lot more CSS than the old one so we should try to remove as
much CSS rules as we can to avoid unneeded complexity.

[mstensho (USE GERRIT), 2014-09-02 17:14:00]

On 2014/09/02 17:03:06, Julien Chaffraix - PST wrote:
> The new test has a lot more CSS than the old one so we should try to remove as
> much CSS rules as we can to avoid unneeded complexity.

Oh, I see. I added column-gap (and -webkit-column-gap), line-height and width. I
removed padding and border, and in my last commit I accidentally removed
column-fill as well (which I do like to specify when I don't want balancing, but
in this case it isn't really necessary, since we overflow the number of columns
specified anyway). I can remove the unprefixed column properties too. We need to
go through all the tests anyway when going unprefixed.

[Julien - ping for review, 2014-09-02 17:52:58]

On 2014/09/02 at 17:14:00, mstensho wrote:
> On 2014/09/02 17:03:06, Julien Chaffraix - PST wrote:
> > The new test has a lot more CSS than the old one so we should try to remove
as
> > much CSS rules as we can to avoid unneeded complexity.
> 
> Oh, I see. I added column-gap (and -webkit-column-gap), line-height and width.
I removed padding and border, and in my last commit I accidentally removed
column-fill as well (which I do like to specify when I don't want balancing, but
in this case it isn't really necessary, since we overflow the number of columns
specified anyway). I can remove the unprefixed column properties too. We need to
go through all the tests anyway when going unprefixed.

That was a general comment about the new test, I leave the actual trimming to
your discretion :-)

[mstensho (USE GERRIT), 2014-09-02 17:56:17]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-09-02 17:57:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mstensho@opera.com/508953004/40001

[commit-bot: I haz the power, 2014-09-02 19:05:33]

Committed patchset #3 (id:40001) as 181248