Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 508953002: Simplify inlining now that the scheduler is smart(er). (Closed)

Created:
6 years, 3 months ago by sigurds
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Simplify inlining now that the scheduler is smart(er). * Only control adjustment is to move everything from the inlinee's start block to the block the call was in. * Add a unit test to ensure that the scheduler actually picks the right order when placing the code. R=mstarzinger@chromium.org, titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -44 lines) Patch
M src/compiler/js-inlining.cc View 2 chunks +2 lines, -35 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sigurds
6 years, 3 months ago (2014-08-27 13:03:24 UTC) #1
Michael Starzinger
LGTM, sweet, love it!
6 years, 3 months ago (2014-08-27 13:41:25 UTC) #2
sigurds
The CQ bit was checked by sigurds@chromium.org
6 years, 3 months ago (2014-08-27 14:38:25 UTC) #3
sigurds
The CQ bit was unchecked by sigurds@chromium.org
6 years, 3 months ago (2014-08-27 14:38:33 UTC) #4
sigurds
The CQ bit was checked by sigurds@chromium.org
6 years, 3 months ago (2014-08-27 14:38:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/sigurds@chromium.org/508953002/1
6 years, 3 months ago (2014-08-27 14:38:57 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 14:38:58 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-27 14:38:58 UTC) #8
sigurds
6 years, 3 months ago (2014-08-28 12:18:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as 23489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698