Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 508933002: Some PNaCL compatibility fixes. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Some PNaCL compatibility fixes. * Removed a few useless and non-standard #includes. * Made OS::GetCurrentProcessId compile without syscall. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23459

Patch Set 1 #

Patch Set 2 : Fix includes for Mac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M src/base/platform/platform-posix.cc View 1 5 chunks +13 lines, -8 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
svenpanne@chromium.org changed reviewers: + bmeurer@chromium.org
6 years, 3 months ago (2014-08-27 12:00:41 UTC) #1
Sven Panne
Just a start, probably a few more CLs to come...
6 years, 3 months ago (2014-08-27 12:00:41 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-08-27 12:02:37 UTC) #3
Sven Panne
6 years, 3 months ago (2014-08-27 13:47:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698