Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 508923002: Fix AndroidRndisForwarder. (Closed)

Created:
6 years, 3 months ago by marja
Modified:
6 years, 3 months ago
Reviewers:
wuhu, tonyg, fmeawad
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix AndroidRndisForwarder. It's trying to use a member variable which doesn't exist, and thus throwing an exception every time it's used. The brokenness was introduced by r290923 ( https://codereview.chromium.org/404803003/ ). BUG= Committed: https://crrev.com/fa221e8cba9aa2f2d887b0aca981d896224b6718 Cr-Commit-Position: refs/heads/master@{#292160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
marja
marja@chromium.org changed reviewers: + duoyi.wu@gmail.com, fmeawad@chromium.org - wuhu@chromium.org
6 years, 3 months ago (2014-08-27 11:15:13 UTC) #1
marja
marja@chromium.org changed reviewers: + wuhu@google.com - duoyi.wu@gmail.com
6 years, 3 months ago (2014-08-27 11:15:43 UTC) #2
marja
tonyg, fmeawad, wuhu, ptal of this trivial fix.
6 years, 3 months ago (2014-08-27 11:16:08 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 3 months ago (2014-08-27 13:55:37 UTC) #4
tonyg
lgtm
6 years, 3 months ago (2014-08-27 13:55:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/508923002/1
6 years, 3 months ago (2014-08-27 13:55:53 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-27 14:56:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 46dc2562f3aaf115f5b31953de66ed39223fb959
6 years, 3 months ago (2014-08-27 15:49:34 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa221e8cba9aa2f2d887b0aca981d896224b6718
Cr-Commit-Position: refs/heads/master@{#292160}

Powered by Google App Engine
This is Rietveld 408576698