Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 508903002: Declaring the weak_ptr_factory in proper order. (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
CC:
lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order. Cleaning up weak_ptr_factory destruction order in "src/ipc" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/0184ced8d904d202ad7ab392ef8eca55d83d2937 Cr-Commit-Position: refs/heads/master@{#292334}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +1 line, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 2 chunks +2 lines, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
anujsharma
anujk.sharma@samsung.com changed reviewers: + l.gombos@samsung.com, sivagunturi@chromium.org, vivekg@chromium.org
6 years, 3 months ago (2014-08-27 09:25:35 UTC) #1
anujsharma
On 2014/08/27 09:25:35, anujk.sharma wrote: > mailto:anujk.sharma@samsung.com changed reviewers: > + mailto:l.gombos@samsung.com, mailto:sivagunturi@chromium.org, mailto:vivekg@chromium.org PTAL
6 years, 3 months ago (2014-08-27 09:26:15 UTC) #2
anujsharma
anujk.sharma@samsung.com changed reviewers: + dmichael@chromium.org, jam@chromium.org - l.gombos@samsung.com, sivagunturi@chromium.org, vivekg@chromium.org
6 years, 3 months ago (2014-08-28 03:18:51 UTC) #3
anujsharma
dmichael@chromium.org: Please review changes in src/ipc module
6 years, 3 months ago (2014-08-28 03:18:51 UTC) #4
anujsharma
On 2014/08/28 03:18:51, anujsharma wrote: > mailto:dmichael@chromium.org: Please review changes in src/ipc module > mailto:jam@chromium.org: ...
6 years, 3 months ago (2014-08-28 03:20:53 UTC) #5
jam
lgtm
6 years, 3 months ago (2014-08-28 03:57:14 UTC) #6
anujsharma
The CQ bit was checked by anujk.sharma@samsung.com
6 years, 3 months ago (2014-08-28 04:10:45 UTC) #7
anujsharma
The CQ bit was unchecked by anujk.sharma@samsung.com
6 years, 3 months ago (2014-08-28 04:10:57 UTC) #8
anujsharma
The CQ bit was checked by anujk.sharma@samsung.com
6 years, 3 months ago (2014-08-28 04:11:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anujk.sharma@samsung.com/508903002/1
6 years, 3 months ago (2014-08-28 04:11:20 UTC) #10
anujsharma
On 2014/08/28 04:11:06, anujsharma wrote: > The CQ bit was checked by mailto:anujk.sharma@samsung.com @Thanks Jam ...
6 years, 3 months ago (2014-08-28 04:12:32 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 04:19:11 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 04:20:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/9869) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/6665) mac_chromium_rel_swarming ...
6 years, 3 months ago (2014-08-28 04:20:52 UTC) #14
anujsharma
On 2014/08/28 04:20:52, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-08-28 05:08:22 UTC) #15
anujsharma
The CQ bit was checked by anujk.sharma@samsung.com
6 years, 3 months ago (2014-08-28 05:08:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anujk.sharma@samsung.com/508903002/20001
6 years, 3 months ago (2014-08-28 05:09:31 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 06:09:00 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 88c1a9834f64469b295157795047264a68c68ef5
6 years, 3 months ago (2014-08-28 06:49:22 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:01 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0184ced8d904d202ad7ab392ef8eca55d83d2937
Cr-Commit-Position: refs/heads/master@{#292334}

Powered by Google App Engine
This is Rietveld 408576698