Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issue 508853002: Context menu should skip any menu construct whose submenu label is the empty string. (Closed)

Created:
6 years, 3 months ago by pals
Modified:
6 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Context menu should skip any menu construct whose submenu label is the empty string. Specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#menu-item-generator "3. Remove from output any menu construct whose submenu label is the empty string." BUG=87553 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html View 2 chunks +9 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu-expected.txt View 1 chunk +9 lines, -6 lines 0 comments Download
M Source/core/page/CustomContextMenuProvider.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pals
sanjoy.pal@samsung.com changed reviewers: + tkent@chromium.org
6 years, 3 months ago (2014-08-27 05:14:01 UTC) #1
pals
The specification is updated and it is more clear now. I have updated the implementation ...
6 years, 3 months ago (2014-08-27 05:16:20 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 3 months ago (2014-08-27 05:19:52 UTC) #3
tkent
lgtm
6 years, 3 months ago (2014-08-27 05:19:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/508853002/1
6 years, 3 months ago (2014-08-27 05:20:12 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 06:21:03 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 06:43:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180936

Powered by Google App Engine
This is Rietveld 408576698