Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 50883004: Decouple lifetime of database thread and WebDatabase, chromium side. (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Decouple lifetime of database thread and WebDatabase, chromium side. Add a method to WebDatabaseObserver to close a database without holding on to an actual WebDatabase. This will make it possible to decouple the lifetime of WebDatabase and the database thread. BUG=249502 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M content/child/web_database_observer_impl.h View 2 chunks +8 lines, -1 line 0 comments Download
M content/child/web_database_observer_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-04 16:18:56 UTC) #1
jochen (gone - plz use gerrit)
plz review
7 years, 1 month ago (2013-11-05 08:04:36 UTC) #2
jam
lgtm
7 years, 1 month ago (2013-11-06 00:18:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/50883004/1
7 years, 1 month ago (2013-11-06 08:03:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220466
7 years, 1 month ago (2013-11-06 10:04:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/50883004/1
7 years, 1 month ago (2013-11-06 10:08:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94807
7 years, 1 month ago (2013-11-06 13:57:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/50883004/1
7 years, 1 month ago (2013-11-06 19:30:01 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 21:11:45 UTC) #9
Message was sent while issue was closed.
Change committed as 233367

Powered by Google App Engine
This is Rietveld 408576698