Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request_http_job.cc

Issue 508823009: Mark SHA-1 as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_verify_result_sha1
Patch Set: Tweak Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « net/cert/cert_verify_proc_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 2ebdd155ba295ea43605ce904dc5ab9ff2f3e2f7..95bdfc10ed1719257a222706ff0682b88a49fae8 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -744,7 +744,8 @@ void URLRequestHttpJob::ProcessStrictTransportSecurityHeader() {
// Only accept HSTS headers on HTTPS connections that have no
// certificate errors.
- if (!ssl_info.is_valid() || IsCertStatusError(ssl_info.cert_status) ||
+ if (!ssl_info.is_valid() || (IsCertStatusError(ssl_info.cert_status) &&
+ !IsCertStatusMinorError(ssl_info.cert_status)) ||
davidben 2014/09/29 20:21:32 Is this bit still necessary now that it's not Cert
!security_state)
return;
@@ -767,7 +768,8 @@ void URLRequestHttpJob::ProcessPublicKeyPinsHeader() {
// Only accept HPKP headers on HTTPS connections that have no
// certificate errors.
- if (!ssl_info.is_valid() || IsCertStatusError(ssl_info.cert_status) ||
+ if (!ssl_info.is_valid() || (IsCertStatusError(ssl_info.cert_status) &&
+ !IsCertStatusMinorError(ssl_info.cert_status)) ||
davidben 2014/09/29 20:21:32 Ditto.
!security_state)
return;
« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « net/cert/cert_verify_proc_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698