Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: net/cert/cert_verify_proc_unittest.cc

Issue 508823009: Mark SHA-1 as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_verify_result_sha1
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/cert_status_flags_list.h ('K') | « net/cert/cert_verify_proc.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc_unittest.cc
diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc
index 8b548f30ea73f8a676d44aa5053d709fe7ea254e..d3c962c47d9adfd861f238a7b77b6762b7b0ad39 100644
--- a/net/cert/cert_verify_proc_unittest.cc
+++ b/net/cert/cert_verify_proc_unittest.cc
@@ -644,7 +644,8 @@ TEST_F(CertVerifyProcTest, TestKnownRoot) {
empty_cert_list_,
&verify_result);
EXPECT_EQ(OK, error);
- EXPECT_EQ(0U, verify_result.cert_status);
+ EXPECT_EQ(CERT_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
+ verify_result.cert_status);
EXPECT_TRUE(verify_result.is_issued_by_known_root);
}
@@ -678,7 +679,8 @@ TEST_F(CertVerifyProcTest, PublicKeyHashes) {
empty_cert_list_,
&verify_result);
EXPECT_EQ(OK, error);
- EXPECT_EQ(0U, verify_result.cert_status);
+ EXPECT_EQ(CERT_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
+ verify_result.cert_status);
ASSERT_LE(2U, verify_result.public_key_hashes.size());
HashValueVector sha1_hashes;
@@ -1076,7 +1078,8 @@ TEST_F(CertVerifyProcTest, CybertrustGTERoot) {
empty_cert_list_,
&verify_result);
EXPECT_EQ(OK, error);
- EXPECT_EQ(0U, verify_result.cert_status);
+ EXPECT_EQ(CERT_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
+ verify_result.cert_status);
// Attempt to verify with the first known cross-certified intermediate
// provided.
@@ -1099,7 +1102,8 @@ TEST_F(CertVerifyProcTest, CybertrustGTERoot) {
empty_cert_list_,
&verify_result);
EXPECT_EQ(OK, error);
- EXPECT_EQ(0U, verify_result.cert_status);
+ EXPECT_EQ(CERT_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
+ verify_result.cert_status);
// Attempt to verify with the second known cross-certified intermediate
// provided.
@@ -1122,7 +1126,8 @@ TEST_F(CertVerifyProcTest, CybertrustGTERoot) {
empty_cert_list_,
&verify_result);
EXPECT_EQ(OK, error);
- EXPECT_EQ(0U, verify_result.cert_status);
+ EXPECT_EQ(CERT_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
+ verify_result.cert_status);
// Attempt to verify when both a cross-certified intermediate AND
// the legacy GTE root are provided.
@@ -1142,7 +1147,8 @@ TEST_F(CertVerifyProcTest, CybertrustGTERoot) {
empty_cert_list_,
&verify_result);
EXPECT_EQ(OK, error);
- EXPECT_EQ(0U, verify_result.cert_status);
+ EXPECT_EQ(CERT_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
+ verify_result.cert_status);
TestRootCerts::GetInstance()->Clear();
EXPECT_TRUE(TestRootCerts::GetInstance()->IsEmpty());
@@ -1240,7 +1246,8 @@ TEST_F(CertVerifyProcTest, CRLSetLeafSerial) {
empty_cert_list_,
&verify_result);
EXPECT_EQ(OK, error);
- EXPECT_EQ(0U, verify_result.cert_status);
+ EXPECT_EQ(CERT_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
+ verify_result.cert_status);
// Test revocation by serial number of a certificate not under the root.
scoped_refptr<CRLSet> crl_set;
« net/cert/cert_status_flags_list.h ('K') | « net/cert/cert_verify_proc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698