tests/toolchain/call_with_misaligned_stack.S - Issue 508823007: Expose LLC's -force-align-stack flag to pnacl-translate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/toolchain/call_with_misaligned_stack.S

Issue 508823007: Expose LLC's -force-align-stack flag to pnacl-translate (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: add test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /*

	2 * Copyright (c) 2014 The Native Client Authors. All rights reserved.

	3 * Use of this source code is governed by a BSD-style license that can be

	4 * found in the LICENSE file.

	5 */

	6

	7 /*

	8 Call the argument with a stack pointer 4 bytes below its value on entry.
	Mark Seaborn 2014/08/28 19:13:13 Nit: Use the NaCl style for multiline comments, wi Nit: Use the NaCl style for multiline comments, with "" prefixing each line: / * Blah... * blah. / Derek Schuff* 2014/08/28 22:07:24 Done. Show quoted text On 2014/08/28 19:13:13, Mark Seaborn wrote: > Nit: Use the NaCl style for multiline comments, with "" prefixing each line: > / > * Blah... > * blah. > */ Done.
	9 This will ensure that (assuming it's aligned on a 16-byte boundary on entry)

	10 it will be misaligned on entry to the callee.

	11 */

	12 .text

	13 .p2align 5

	14 .globl call_with_misaligned_stack

	15 .type call_with_misaligned_stack, @function

	16 call_with_misaligned_stack:

	17 movl 4(%esp), %ecx /* call target */

	18 naclcall %ecx

	19 pop %ecx

	20 nacljmp %ecx

	21 .p2align 5

OLD	NEW

« no previous file with comments | « pnacl/driver/pnacl-translate.py ('k') | tests/toolchain/nacl.scons » ('j') | tests/toolchain/nacl.scons » ('J')