Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 508823004: gn: Fix definition of |enable_plugins|. (Closed)

Created:
6 years, 3 months ago by sadrul
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/39a6a1b1e570f54aaa957095400b6d40aae0e0f1 Cr-Commit-Position: refs/heads/master@{#292256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
sadrul@chromium.org changed reviewers: + brettw@chromium.org
6 years, 3 months ago (2014-08-27 13:44:23 UTC) #1
sadrul
6 years, 3 months ago (2014-08-27 13:44:24 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-08-27 20:00:01 UTC) #3
sadrul
Committed patchset #1 to pending queue manually as 0de0897 (presubmit successful).
6 years, 3 months ago (2014-08-27 22:57:05 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39a6a1b1e570f54aaa957095400b6d40aae0e0f1
Cr-Commit-Position: refs/heads/master@{#292256}

Powered by Google App Engine
This is Rietveld 408576698