chrome/browser/ui/app_list/app_list_view_delegate.h - Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_view_delegate.h

Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_shower_views_unittest.cc ('k') | chrome/browser/ui/app_list/app_list_view_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_view_delegate.h

diff --git a/chrome/browser/ui/app_list/app_list_view_delegate.h b/chrome/browser/ui/app_list/app_list_view_delegate.h

index 5aa6ba8bf50ffa2f96c932ed99e8736ade5102fd..8f8c805d2edbfd35af3ffe9cd2e574c887270046 100644

--- a/chrome/browser/ui/app_list/app_list_view_delegate.h

+++ b/chrome/browser/ui/app_list/app_list_view_delegate.h

@@ -55,16 +55,16 @@ class AppListViewDelegate : public app_list::AppListViewDelegate,

public SigninManagerFactory::Observer,

public content::NotificationObserver {

public:

- // Constructs Chrome's AppListViewDelegate, initially for |profile|.

+ // Constructs Chrome's AppListViewDelegate with a NULL Profile.

// Does not take ownership of |controller|. TODO(tapted): It should.

- AppListViewDelegate(Profile* profile,

- AppListControllerDelegate* controller);

+ explicit AppListViewDelegate(AppListControllerDelegate* controller);

virtual ~AppListViewDelegate();

- private:

// Configure the AppList for the given |profile|.

void SetProfile(Profile* profile);

+ Profile* profile() { return profile_; }

+ private:

// Updates the speech webview and start page for the current |profile_|.

void SetUpSearchUI();