chrome/browser/ui/app_list/app_list_shower_views.cc - Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_shower_views.cc

Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_shower_delegate.h ('k') | chrome/browser/ui/app_list/app_list_shower_views_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_shower_views.cc

diff --git a/chrome/browser/ui/app_list/app_list_shower_views.cc b/chrome/browser/ui/app_list/app_list_shower_views.cc

index 33dfa30e3be8ee7dd36fd9bbe690d039157bdc22..90ed38fe9ce0eed380688059fad6b1b4e31914de 100644

--- a/chrome/browser/ui/app_list/app_list_shower_views.cc

+++ b/chrome/browser/ui/app_list/app_list_shower_views.cc

@@ -99,11 +99,9 @@ bool AppListShower::HasView() const {

}

app_list::AppListView* AppListShower::MakeViewForCurrentProfile() {

- // The view delegate will be owned by the app list view. The app list view

- // manages its own lifetime.

- AppListViewDelegate* view_delegate = new AppListViewDelegate(

- profile_, delegate_->GetControllerDelegateForCreate());

- app_list::AppListView* view = new app_list::AppListView(view_delegate);

+ // The app list view manages its own lifetime.

+ app_list::AppListView* view =

+ new app_list::AppListView(delegate_->GetViewDelegateForCreate());

gfx::Point cursor = gfx::Screen::GetNativeScreen()->GetCursorScreenPoint();

view->InitAsBubbleAtFixedLocation(NULL,