Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: ash/shell_delegate.h

Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell/shell_delegate_impl.cc ('k') | ash/test/test_shell_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell_delegate.h
diff --git a/ash/shell_delegate.h b/ash/shell_delegate.h
index d41132b5f78e15aea6a50dccd126f28fce9a8102..148f6867ca331a981be886ccc024a4bbb85e5ff4 100644
--- a/ash/shell_delegate.h
+++ b/ash/shell_delegate.h
@@ -111,9 +111,9 @@ class ASH_EXPORT ShellDelegate {
// in chrome.
virtual content::BrowserContext* GetActiveBrowserContext() = 0;
- // Invoked to create an AppListViewDelegate. Shell takes the ownership of
- // the created delegate.
- virtual app_list::AppListViewDelegate* CreateAppListViewDelegate() = 0;
+ // Get the AppListViewDelegate, creating one if it does not yet exist.
+ // Ownership stays with Chrome's AppListService, or the ShellDelegate.
+ virtual app_list::AppListViewDelegate* GetAppListViewDelegate() = 0;
// Creates a new ShelfDelegate. Shell takes ownership of the returned
// value.
« no previous file with comments | « ash/shell/shell_delegate_impl.cc ('k') | ash/test/test_shell_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698