Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: ash/wm/app_list_controller.cc

Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase to master Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/app_list_controller.cc
diff --git a/ash/wm/app_list_controller.cc b/ash/wm/app_list_controller.cc
index 515930507524e271db77b1229ca0f4c2a70ea10a..f98fe839f2b8eed851e62de80ce0c452bb6c673c 100644
--- a/ash/wm/app_list_controller.cc
+++ b/ash/wm/app_list_controller.cc
@@ -190,7 +190,7 @@ void AppListController::Show(aura::Window* window) {
// AppListModel and AppListViewDelegate are owned by AppListView. They
James Cook 2014/09/18 23:29:55 nit: Is this comment still correct?
tapted 2014/09/19 00:49:01 The model comment hasn't been right for a while (i
// will be released with AppListView on close.
app_list::AppListView* view = new app_list::AppListView(
- Shell::GetInstance()->delegate()->CreateAppListViewDelegate());
+ Shell::GetInstance()->delegate()->GetAppListViewDelegate());
aura::Window* root_window = window->GetRootWindow();
aura::Window* container = GetRootWindowController(root_window)->
GetContainer(kShellWindowId_AppListContainer);

Powered by Google App Engine
This is Rietveld 408576698