Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 508803003: net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL. (Closed)

Created:
6 years, 3 months ago by agl
Modified:
6 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL. This enables 1/n-1 record splitting, which we have done with NSS for a long time. No compat issues are expected with this. (This does not appear to be a regression from the OpenSSL -> BoringSSL switch as I don't see that a record splitting patch was previously included.) BUG=none Committed: https://crrev.com/e06bd13395c1ed5d93dd35ff3572a79f08bfbab8 Cr-Commit-Position: refs/heads/master@{#292197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
agl
agl@chromium.org changed reviewers: + davidben@chromium.org
6 years, 3 months ago (2014-08-27 00:10:16 UTC) #1
agl
6 years, 3 months ago (2014-08-27 00:10:16 UTC) #2
davidben
Oh, did we never actually turn this on? lgtm
6 years, 3 months ago (2014-08-27 00:31:10 UTC) #3
agl
The CQ bit was checked by agl@chromium.org
6 years, 3 months ago (2014-08-27 17:41:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/508803003/1
6 years, 3 months ago (2014-08-27 17:42:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4fd9d2c814ec674af9bebd6e534695dcaec338ae
6 years, 3 months ago (2014-08-27 18:55:43 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e06bd13395c1ed5d93dd35ff3572a79f08bfbab8
Cr-Commit-Position: refs/heads/master@{#292197}

Powered by Google App Engine
This is Rietveld 408576698