Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 508793002: Check for integer overflow when HMAC key length as bits cannot fit in an unsigned int. (Closed)

Created:
6 years, 3 months ago by eroman
Modified:
6 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check for integer overflow when HMAC key length as bits cannot fit in an unsigned int. Committed: https://crrev.com/42e82923357fd24d2bd0e028d13f317c0b9474a7 Cr-Commit-Position: refs/heads/master@{#292203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -18 lines) Patch
M content/child/webcrypto/nss/hmac_nss.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M content/child/webcrypto/openssl/hmac_openssl.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M content/child/webcrypto/test/hmac_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
eroman@chromium.org changed reviewers: + rsleevi@chromium.org
6 years, 3 months ago (2014-08-26 22:19:35 UTC) #1
eroman
6 years, 3 months ago (2014-08-26 22:19:35 UTC) #2
Ryan Sleevi
lgtm
6 years, 3 months ago (2014-08-27 17:11:28 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 3 months ago (2014-08-27 17:33:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/508793002/1
6 years, 3 months ago (2014-08-27 17:33:49 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 18:43:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0f70a4370ddf412af034ad15efc9effcedcd1ab9
6 years, 3 months ago (2014-08-27 19:10:19 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42e82923357fd24d2bd0e028d13f317c0b9474a7
Cr-Commit-Position: refs/heads/master@{#292203}

Powered by Google App Engine
This is Rietveld 408576698