chrome/common/extensions/api/extension_action/action_info.cc - Issue 508783002: Update old syntax for action default_icon to populate 19 and 38px icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 508783002: Update old syntax for action default_icon to populate 19 and 38px icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Docs update Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/common/extensions/docs/templates/intros/browserAction.html » ('j') | chrome/common/extensions/docs/templates/intros/browserAction.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/action_info.cc

diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc

index f974c1d0bc0bc179590b3eaa7e2397985e6a94fa..a733cbdcdc8036c480ba9af868925dd3c1ecb8c8 100644

--- a/chrome/common/extensions/api/extension_action/action_info.cc

+++ b/chrome/common/extensions/api/extension_action/action_info.cc

@@ -104,6 +104,8 @@ scoped_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,

&default_icon)) {

result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION,

default_icon);

not at google - send to devlin 2014/08/26 22:25:41 The default icon logic will automatically scale do

gpdavis 2014/08/26 23:24:43 Done.

+ result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION * 2,

+ default_icon);

} else {

*error = base::ASCIIToUTF16(errors::kInvalidPageActionIconPath);

return scoped_ptr<ActionInfo>();