Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 508743002: Whitelist the internal hotrod apps. (Closed)

Created:
6 years, 3 months ago by xiyuan
Modified:
6 years, 3 months ago
Reviewers:
miket_OOO, zel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Whitelist the internal hotrod apps. BUG=407693 Committed: https://crrev.com/b0eb4cc353dbed2969a8cbdaa3888559cef02aa8 Cr-Commit-Position: refs/heads/master@{#292185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 8 chunks +40 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
xiyuan
xiyuan@chromium.org changed reviewers: + miket@chromium.org, zelidrag@chromium.org
6 years, 3 months ago (2014-08-26 20:31:34 UTC) #1
xiyuan
6 years, 3 months ago (2014-08-26 20:31:35 UTC) #2
zel
The CQ bit was checked by zelidrag@chromium.org
6 years, 3 months ago (2014-08-26 21:21:36 UTC) #3
zel
The CQ bit was unchecked by zelidrag@chromium.org
6 years, 3 months ago (2014-08-26 21:21:37 UTC) #4
zel
lgtm
6 years, 3 months ago (2014-08-26 21:21:42 UTC) #5
zel
The CQ bit was checked by zelidrag@chromium.org
6 years, 3 months ago (2014-08-26 21:22:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/508743002/1
6 years, 3 months ago (2014-08-26 21:23:45 UTC) #7
xiyuan
Mike, we need owner's blessing for this CL. Thanks.
6 years, 3 months ago (2014-08-26 21:24:57 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 22:11:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 22:16:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6806)
6 years, 3 months ago (2014-08-26 22:16:58 UTC) #11
miket_OOO
I don't see these hashes listed anywhere on http://go/chrome-api-whitelist, including on https://code.google.com/p/chromium/issues/detail?id=389230. Will you please ...
6 years, 3 months ago (2014-08-27 17:40:42 UTC) #12
xiyuan
On 2014/08/27 17:40:42, miket wrote: > I don't see these hashes listed anywhere on http://go/chrome-api-whitelist, ...
6 years, 3 months ago (2014-08-27 18:04:52 UTC) #13
miket_OOO
lgtm
6 years, 3 months ago (2014-08-27 18:08:27 UTC) #14
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 3 months ago (2014-08-27 18:09:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/508743002/1
6 years, 3 months ago (2014-08-27 18:11:18 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8bfb891a63e7172fbb6a29d9f085aac8acd57d40
6 years, 3 months ago (2014-08-27 18:15:08 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:46 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0eb4cc353dbed2969a8cbdaa3888559cef02aa8
Cr-Commit-Position: refs/heads/master@{#292185}

Powered by Google App Engine
This is Rietveld 408576698