Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/bisect-perf-regression.py

Issue 508723004: Use Git hash to post try job http request to bisect builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 21ec83503a8b86e26d258ede7c2bd348506cad3d..05798e17bbf2511cf20df304e613e42983e56a24 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -1358,8 +1358,10 @@ class BisectPerformanceMetrics(object):
'%s-%s-%s' % (svn_revision, patch, time.time()))
qyearsley 2014/08/27 16:41:55 Perhaps the build ID request should use the git ha
# Creates a try job description.
+ # Always use Git hash to post build request since Commit positions are
+ # not supported by builders to build.
job_args = {
- 'revision': 'src@%s' % svn_revision,
+ 'revision': 'src@%s' % revision,
'bot': bot_name,
'name': build_request_id,
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698