Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 508713002: Exclude two tests in SearchProviderTest for dereferencing NULL under memory checkers. (Closed)

Created:
6 years, 3 months ago by Jeffrey Yasskin
Modified:
6 years, 3 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Exclude SearchProviderTest.* for dereferencing NULL under memory checkers. BUG=407750 TBR=hashimoto@chromium.org NOTRY=true Committed: https://crrev.com/ee1325c2df836f5622a31c04208fbfac2a5c82e6 Cr-Commit-Position: refs/heads/master@{#291960}

Patch Set 1 #

Patch Set 2 : Disable all of SearchProviderTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/unit_tests.gtest.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 3 months ago (2014-08-26 19:02:44 UTC) #1
Jeffrey Yasskin
The CQ bit was unchecked by jyasskin@chromium.org
6 years, 3 months ago (2014-08-26 19:04:05 UTC) #2
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 3 months ago (2014-08-26 19:05:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/508713002/20001
6 years, 3 months ago (2014-08-26 19:06:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 19:07:47 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 19:07:48 UTC) #6
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 3 months ago (2014-08-26 19:11:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/508713002/20001
6 years, 3 months ago (2014-08-26 19:12:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (20001) as c61c1d39c2411cfe4c26eda8ed8a725d04082780
6 years, 3 months ago (2014-08-26 19:20:41 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:47 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ee1325c2df836f5622a31c04208fbfac2a5c82e6
Cr-Commit-Position: refs/heads/master@{#291960}

Powered by Google App Engine
This is Rietveld 408576698