Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 508683002: Remove implicit conversions from scoped_refptr to T* in content/browser/fileapi/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
jianli
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/browser/fileapi/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/263399781b14e9c3e9748659e64e8301a811f63f Cr-Commit-Position: refs/heads/master@{#291941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M content/browser/fileapi/blob_url_request_job_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_file_stream_reader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + jianli@chromium.org
6 years, 3 months ago (2014-08-26 17:13:08 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 17:13:08 UTC) #2
jianli
lgtm
6 years, 3 months ago (2014-08-26 17:17:17 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 17:17:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/508683002/1
6 years, 3 months ago (2014-08-26 17:19:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 123c720ec35c27a7e1f268ada91c94f82cd91497
6 years, 3 months ago (2014-08-26 18:11:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/263399781b14e9c3e9748659e64e8301a811f63f
Cr-Commit-Position: refs/heads/master@{#291941}

Powered by Google App Engine
This is Rietveld 408576698