Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 508673002: MIPS: Move register conventions out of the IC classes. (Closed)

Created:
6 years, 3 months ago by balazs.kilvady
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Move register conventions out of the IC classes. Port r23391 (c3bf1dc) Original commit message: A change to a convention shouldn't require recompilation of ic.h/.cc. BUG= R=paul.lind@imgtec.com, vogelheim@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23420

Patch Set 1 #

Patch Set 2 : Fix indentation. #

Patch Set 3 : Fix BUILD.gn #

Total comments: 2

Patch Set 4 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -359 lines) Patch
M BUILD.gn View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/ic/mips/access-compiler-mips.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/ic/mips/ic-conventions-mips.cc View 1 2 3 2 chunks +10 lines, -11 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 16 chunks +38 lines, -60 lines 0 comments Download
M src/ic/mips64/access-compiler-mips64.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/ic/mips64/ic-conventions-mips64.cc View 1 2 3 2 chunks +10 lines, -11 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 16 chunks +38 lines, -60 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/debug-mips.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 24 chunks +60 lines, -55 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M src/mips/lithium-mips.cc View 5 chunks +17 lines, -13 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/debug-mips64.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 24 chunks +60 lines, -55 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 5 chunks +16 lines, -15 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 5 chunks +17 lines, -13 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
balazs.kilvady
balazs.kilvady@imgtec.com changed reviewers: + akos.palfi@imgtec.com, danno@chromium.org, dusan.milosavljevic@imgtec.com, gergely.kis@imgtec.com, mvstanton@chromium.org, paul.lind@imgtec.com
6 years, 3 months ago (2014-08-26 15:45:56 UTC) #1
balazs.kilvady
6 years, 3 months ago (2014-08-26 15:46:07 UTC) #2
balazs.kilvady
Indentation fixed.
6 years, 3 months ago (2014-08-26 15:58:11 UTC) #3
paul.l...
paul.lind@imgtec.com changed reviewers: + verwaest@chromium.org
6 years, 3 months ago (2014-08-26 16:15:11 UTC) #4
paul.l...
LGTM. Could a v8 team member also review, for gyp & gn file changes?
6 years, 3 months ago (2014-08-26 16:15:11 UTC) #5
balazs.kilvady
Fix BUILD.gn
6 years, 3 months ago (2014-08-26 16:25:42 UTC) #6
paul.l...
paul.lind@imgtec.com changed reviewers: + machenbach@chromium.org
6 years, 3 months ago (2014-08-26 16:33:14 UTC) #7
paul.l...
Still LGTM. Added Michael as reviewer as well.
6 years, 3 months ago (2014-08-26 16:33:14 UTC) #8
paul.l...
paul.lind@imgtec.com changed reviewers: + vogelheim@chromium.org
6 years, 3 months ago (2014-08-26 17:29:44 UTC) #9
paul.l...
Adding vogelheim (sheriff) as reviewer too ... just trying to get this mips-breaking change landed ...
6 years, 3 months ago (2014-08-26 17:29:44 UTC) #10
vogelheim
lgtm (I don't have much to say on the substance on the change, though. gyp+GN ...
6 years, 3 months ago (2014-08-26 17:42:37 UTC) #11
balazs.kilvady
https://codereview.chromium.org/508673002/diff/40001/src/ic/mips/ic-conventions-mips.cc File src/ic/mips/ic-conventions-mips.cc (right): https://codereview.chromium.org/508673002/diff/40001/src/ic/mips/ic-conventions-mips.cc#newcode35 src/ic/mips/ic-conventions-mips.cc:35: On 2014/08/26 17:42:37, vogelheim wrote: > nitpick: why the ...
6 years, 3 months ago (2014-08-26 17:52:27 UTC) #12
balazs.kilvady
Committed patchset #4 manually as r23420 (tree was closed).
6 years, 3 months ago (2014-08-26 17:57:41 UTC) #13
mvstanton
6 years, 3 months ago (2014-08-27 07:50:38 UTC) #14
Message was sent while issue was closed. 
yep, lgtm here.

Powered by Google App Engine
This is Rietveld 408576698