Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 50863002: Use register allocator for context on x64. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Use register allocator for context on x64. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17585

Patch Set 1 #

Total comments: 2

Patch Set 2 : added comment to test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -277 lines) Patch
M src/hydrogen.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 6 chunks +9 lines, -9 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 51 chunks +114 lines, -33 lines 0 comments Download
M src/x64/lithium-x64.h View 30 chunks +248 lines, -130 lines 0 comments Download
M src/x64/lithium-x64.cc View 26 chunks +96 lines, -49 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M test/cctest/test-code-stubs-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
In unoptimized code, we use a fixed register for the context (esi, rsi, cp). In ...
7 years, 1 month ago (2013-10-29 14:33:18 UTC) #1
mvstanton
lgtm, small nit. https://codereview.chromium.org/50863002/diff/1/src/hydrogen.cc File src/hydrogen.cc (left): https://codereview.chromium.org/50863002/diff/1/src/hydrogen.cc#oldcode6513 src/hydrogen.cc:6513: #if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_MIPS ...
7 years, 1 month ago (2013-10-31 08:39:24 UTC) #2
Yang
7 years, 1 month ago (2013-11-08 10:59:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698