Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 508593003: Update font preference to use Noto Sans CJK on CrOS (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat, sky
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Update font preference to use Noto Sans CJK on CrOS Noto Sans CJK is a new set of CJK fonts released by Google and Adobe on July 11. They have been developed with the harmony with Noto Sans (LGC) to be used together. For CJK, we don't need to use licensed fonts, 3rd party fonts, or Droid Sans Fallback any more. While I'm at it, replace 'Open Sans' (that CrOS deviced do not have) with 'Noto Sans UI' (the default UI font on CrOS for Latin-Greek-Cyrillic) and remove a reference to 'Droid Sans Fallback' (that is going to be removed in a separate CrOS CL). This CL will go in after the CrOS CL to add Noto Sans CJK is landed. ( https://chromium-review.googlesource.com/212624 ) BUG=399080 TEST=Start CrOS in 4 CJK locales and see the fonts set (noto Sans CJK <lang>) here are used. TBR=derat@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/476123002 Cr-Commit-Position: refs/heads/master@{#290138} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290138 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit db681ab00427e68df6ac524e711e6d13f7efff6f) Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/304e59b

Patch Set 1 #

Patch Set 2 : rebase to the branch head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -63 lines) Patch
M chrome/app/resources/locale_settings_chromiumos.grd View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/app/resources/locale_settings_google_chromeos.grd View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_ja.xtb View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_ko.xtb View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/gesture_config.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/audio_player/css/audio_player.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/audio_player/elements/track_list.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/css/video_player.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ja.xtb View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/strings/translations/app_locale_settings_ko.xtb View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/strings/translations/app_locale_settings_zh-CN.xtb View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/strings/translations/app_locale_settings_zh-TW.xtb View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
6 years, 3 months ago (2014-08-26 16:53:39 UTC) #1
jungshik at Google
Committed patchset #2 to pending queue manually as 304e59b (presubmit successful).
6 years, 3 months ago (2014-08-26 16:55:03 UTC) #2
Daniel Erat
6 years, 3 months ago (2014-08-26 17:03:46 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698