Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: chrome/browser/extensions/page_action_controller_unittest.cc

Issue 508563003: Remove PageActionsController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_controller_unittest.cc
diff --git a/chrome/browser/extensions/page_action_controller_unittest.cc b/chrome/browser/extensions/page_action_controller_unittest.cc
deleted file mode 100644
index 032cc3a19940139bc3bf822244b93091bde51c73..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/page_action_controller_unittest.cc
+++ /dev/null
@@ -1,112 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <string>
-
-#include "base/command_line.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
-#include "chrome/browser/extensions/extension_action.h"
-#include "chrome/browser/extensions/extension_action_manager.h"
-#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/extensions/page_action_controller.h"
-#include "chrome/browser/extensions/tab_helper.h"
-#include "chrome/browser/extensions/test_extension_system.h"
-#include "chrome/browser/sessions/session_tab_helper.h"
-#include "chrome/test/base/chrome_render_view_host_test_harness.h"
-#include "chrome/test/base/testing_profile.h"
-#include "extensions/common/extension.h"
-#include "extensions/common/extension_builder.h"
-#include "extensions/common/value_builder.h"
-
-#if defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
-#include "chrome/browser/chromeos/settings/cros_settings.h"
-#include "chrome/browser/chromeos/settings/device_settings_service.h"
-#endif
-
-namespace extensions {
-namespace {
-
-class PageActionControllerTest : public ChromeRenderViewHostTestHarness {
- protected:
- virtual void SetUp() OVERRIDE {
- ChromeRenderViewHostTestHarness::SetUp();
-#if defined OS_CHROMEOS
- test_user_manager_.reset(new chromeos::ScopedTestUserManager());
-#endif
- TabHelper::CreateForWebContents(web_contents());
- // Create an ExtensionService so the PageActionController can find its
- // extensions.
- CommandLine command_line(CommandLine::NO_PROGRAM);
- Profile* profile =
- Profile::FromBrowserContext(web_contents()->GetBrowserContext());
- extension_service_ = static_cast<TestExtensionSystem*>(
- ExtensionSystem::Get(profile))->CreateExtensionService(
- &command_line, base::FilePath(), false);
- }
-
- virtual void TearDown() OVERRIDE {
-#if defined OS_CHROMEOS
- test_user_manager_.reset();
-#endif
- ChromeRenderViewHostTestHarness::TearDown();
- }
-
- int tab_id() {
- return SessionTabHelper::IdForTab(web_contents());
- }
-
- ExtensionService* extension_service_;
-
- private:
-#if defined OS_CHROMEOS
- chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
- chromeos::ScopedTestCrosSettings test_cros_settings_;
- scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
-#endif
-};
-
-TEST_F(PageActionControllerTest, NavigationClearsState) {
- scoped_refptr<const Extension> extension =
- ExtensionBuilder()
- .SetManifest(DictionaryBuilder()
- .Set("name", "Extension with page action")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)
- .Set("permissions", ListBuilder()
- .Append("tabs"))
- .Set("page_action", DictionaryBuilder()
- .Set("default_title", "Hello")))
- .Build();
- extension_service_->AddExtension(extension.get());
-
- NavigateAndCommit(GURL("http://www.google.com"));
-
- ExtensionAction& page_action =
- *ExtensionActionManager::Get(profile())->GetPageAction(*extension.get());
- page_action.SetTitle(tab_id(), "Goodbye");
- page_action.SetPopupUrl(
- tab_id(), extension->GetResourceURL("popup.html"));
-
- EXPECT_EQ("Goodbye", page_action.GetTitle(tab_id()));
- EXPECT_EQ(extension->GetResourceURL("popup.html"),
- page_action.GetPopupUrl(tab_id()));
-
- // Within-page navigation should keep the settings.
- NavigateAndCommit(GURL("http://www.google.com/#hash"));
-
- EXPECT_EQ("Goodbye", page_action.GetTitle(tab_id()));
- EXPECT_EQ(extension->GetResourceURL("popup.html"),
- page_action.GetPopupUrl(tab_id()));
-
- // Should discard the settings, and go back to the defaults.
- NavigateAndCommit(GURL("http://www.yahoo.com"));
-
- EXPECT_EQ("Hello", page_action.GetTitle(tab_id()));
- EXPECT_EQ(GURL(), page_action.GetPopupUrl(tab_id()));
-};
-
-} // namespace
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698