Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 508543002: OOP PDF - Allow OOP PDF to use histograms (Closed)

Created:
6 years, 4 months ago by Nikhil
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OOP PDF - Allow OOP PDF to use histograms This patch adds libpdf.so to whitelisted plugins so that it can use histograms. Without this patch, an error is displayed every time when Chrome is launched with OOP PDF flag and PDF file is opened. BUG=405305 Committed: https://crrev.com/3c922e3f2152399787cdf8f800c5c7f71af78308 Cr-Commit-Position: refs/heads/master@{#292109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/renderer/pepper/pepper_uma_host.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Nikhil
n.bansal@samsung.com changed reviewers: + raymes@chromium.org
6 years, 4 months ago (2014-08-26 08:37:22 UTC) #1
Nikhil
n.bansal@samsung.com changed reviewers: + thestig@chromium.org
6 years, 4 months ago (2014-08-26 08:37:38 UTC) #2
Nikhil
PTAL at my proposed solution to fix histogram related error that is shown every time ...
6 years, 4 months ago (2014-08-26 08:39:37 UTC) #3
raymes
lgtm - as long as you have tested that it actually fixes the bug :)
6 years, 3 months ago (2014-08-27 01:03:47 UTC) #4
Nikhil
On 2014/08/27 01:03:47, raymes wrote: > lgtm - as long as you have tested that ...
6 years, 3 months ago (2014-08-27 05:32:22 UTC) #5
raymes
On 2014/08/27 05:32:22, Nikhil wrote: > On 2014/08/27 01:03:47, raymes wrote: > > lgtm - ...
6 years, 3 months ago (2014-08-27 05:41:43 UTC) #6
Nikhil
The CQ bit was checked by n.bansal@samsung.com
6 years, 3 months ago (2014-08-27 05:42:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/508543002/1
6 years, 3 months ago (2014-08-27 05:43:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (1) as d3eb517e681bda3623b24ca485066191bac8e279
6 years, 3 months ago (2014-08-27 06:51:11 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c922e3f2152399787cdf8f800c5c7f71af78308
Cr-Commit-Position: refs/heads/master@{#292109}

Powered by Google App Engine
This is Rietveld 408576698