chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/blacklist_state_fetcher.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/signin/chrome_signin_client.h"	5 #include "chrome/browser/signin/chrome_signin_client.h"

6 #include "chrome/browser/signin/chrome_signin_client_factory.h"	6 #include "chrome/browser/signin/chrome_signin_client_factory.h"

7 #include "chrome/browser/signin/signin_manager_factory.h"	7 #include "chrome/browser/signin/signin_manager_factory.h"

8 #include "chrome/test/base/testing_browser_process.h"	8 #include "chrome/test/base/testing_browser_process.h"

9 #include "chrome/test/base/testing_profile.h"	9 #include "chrome/test/base/testing_profile.h"

10 #include "chrome/test/base/testing_profile_manager.h"	10 #include "chrome/test/base/testing_profile_manager.h"

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
68 ChromeSigninClientFactory::GetForProfile(profile_);	68 ChromeSigninClientFactory::GetForProfile(profile_);

69 ASSERT_TRUE(signin_client);	69 ASSERT_TRUE(signin_client);

70 signin_client->SetSigninProcess(signin_process.GetID());	70 signin_client->SetSigninProcess(signin_process.GetID());

71	71

72 scoped_refptr<const Extension> extension(CreateTestExtension("a"));	72 scoped_refptr<const Extension> extension(CreateTestExtension("a"));

73 std::string error;	73 std::string error;

74	74

75 // The same call should succeed with a normal process, but fail with a signin	75 // The same call should succeed with a normal process, but fail with a signin

76 // process.	76 // process.

77 const PermissionsData* permissions_data = extension->permissions_data();	77 const PermissionsData* permissions_data = extension->permissions_data();

78 EXPECT_TRUE(permissions_data->CanAccessPage(extension,	78 EXPECT_TRUE(permissions_data->CanAccessPage(extension.get(),

79 kSigninUrl,	79 kSigninUrl,

80 kSigninUrl,	80 kSigninUrl,

81 -1, // no tab id.	81 -1, // no tab id.

82 normal_process.GetID(),	82 normal_process.GetID(),

83 &error))	83 &error))

84 << error;	84 << error;

85 EXPECT_FALSE(permissions_data->CanAccessPage(extension,	85 EXPECT_FALSE(permissions_data->CanAccessPage(extension.get(),

86 kSigninUrl,	86 kSigninUrl,

87 kSigninUrl,	87 kSigninUrl,

88 -1, // no tab id.	88 -1, // no tab id.

89 signin_process.GetID(),	89 signin_process.GetID(),

90 &error))	90 &error))

91 << error;	91 << error;

92 }	92 }

93 #endif	93 #endif

94	94

95 } // namespace extensions	95 } // namespace extensions

OLD	NEW