Use WaitForDebuggerChildren to let renderer wait for gdb

content/public/common/content_switches.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines all the "content" command-line switches.
 
 #ifndef CONTENT_PUBLIC_COMMON_CONTENT_SWITCHES_H_
 #define CONTENT_PUBLIC_COMMON_CONTENT_SWITCHES_H_
 
 #include "build/build_config.h"
@@ skipping 216 matching lines @@
 CONTENT_EXPORT extern const char kUseFakeUIForMediaStream[];
 CONTENT_EXPORT extern const char kUseMobileUserAgent[];
 extern const char kUseSurfaces[];
 extern const char kUtilityCmdPrefix[];
 CONTENT_EXPORT extern const char kUtilityProcess[];
 extern const char kUtilityProcessAllowedDir[];
 CONTENT_EXPORT extern const char kUtilityProcessEnableMDns[];
 CONTENT_EXPORT extern const char kUtilityProcessRunningElevated[];
 extern const char kV8CacheOptions[];
 CONTENT_EXPORT extern const char kValidateInputEventStream[];
 CONTENT_EXPORT extern const char kWaitForDebuggerChildren[];

[Charlie Reis, 2014/08/29 00:04:24]

How does the new flag differ from this one?

[Jaekyun Seok (inactive), 2014/08/29 01:05:07]

Maybe we can reuse it, but it is a flag for all child processes.

So, setting it to let renderer process wait for a debugger may affect other
processes unexpectedly.

[Feng Qian, 2014/08/29 15:57:35]

We should reuse it, render is a child process.
Right now, only child process is renderer process.


On 2014/08/29 01:05:07, Jaekyun Seok wrote:

[Jaekyun Seok (inactive), 2014/08/29 22:08:01]

I didn't know that renderer process is only one, and I realized that
kWaitForDebuggerChildren can have a value to determine if the child process
should have the kWaitForDebugger flag passed on or not.

So I will reuse it.

 CONTENT_EXPORT extern const char kZygoteCmdPrefix[];
 CONTENT_EXPORT extern const char kZygoteProcess[];
 
 #if defined(ENABLE_WEBRTC)
 CONTENT_EXPORT extern const char kDisableAudioTrackProcessing[];
 CONTENT_EXPORT extern const char kDisableWebRtcHWDecoding[];
 CONTENT_EXPORT extern const char kDisableWebRtcEncryption[];
 CONTENT_EXPORT extern const char kDisableWebRtcHWEncoding[];
 CONTENT_EXPORT extern const char kEnableWebRtcHWVp8Encoding[];
 CONTENT_EXPORT extern const char kEnableWebRtcHWH264Encoding[];
@@ skipping 30 matching lines @@
 // This switch contains the device scale factor passed to certain processes
 // like renderers, etc.
 CONTENT_EXPORT extern const char kDeviceScaleFactor[];
 CONTENT_EXPORT extern const char kDisableDirectWrite[];
 CONTENT_EXPORT extern const char kDisableLegacyIntermediateWindow[];
 // This switch will be removed when we enable the win32K lockdown process
 // mitigation.
 CONTENT_EXPORT extern const char kEnableWin32kRendererLockDown[];
 #endif
 
+CONTENT_EXPORT extern const char kRendererWaitForDebugger[];

[Charlie Reis, 2014/08/29 00:04:24]

See the comment below.  Please alphabetize this above.

[Jaekyun Seok (inactive), 2014/08/29 01:05:08]

Done.

+
 // DON'T ADD RANDOM STUFF HERE. Put it in the main section above in
 // alphabetical order, or in one of the ifdefs (also in order in each section).
 
 }  // namespace switches
 
 #endif  // CONTENT_PUBLIC_COMMON_CONTENT_SWITCHES_H_