Store local auth credentials after successful login or re-auth.

chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
index 25dce577bab4195c74b0dca0db4b15ab9c30bd84..177e3c549486eff24e5947210f6501a4dbe468f2 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
@@ -14,6 +14,7 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/about_signin_internals_factory.h"
 #include "chrome/browser/signin/chrome_signin_client_factory.h"
+#include "chrome/browser/signin/local_auth.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
@@ -115,10 +116,19 @@ void InlineSigninHelper::OnSigninOAuthInformationAvailable(
   }
 
   AboutSigninInternals* about_signin_internals =
-    AboutSigninInternalsFactory::GetForProfile(profile_);
+      AboutSigninInternalsFactory::GetForProfile(profile_);
   about_signin_internals->OnRefreshTokenReceived("Successful");
 
   signin::Source source = signin::GetSourceForPromoURL(current_url_);
+
+  std::string primary_email =
+      SigninManagerFactory::GetForProfile(profile_)->GetAuthenticatedUsername();
+  bool is_primary_account =
+      gaia::AreEmailsSame(email, primary_email) ||
+      source == signin::SOURCE_AVATAR_BUBBLE_SIGN_IN;
+  if (is_primary_account)

[Marc Treib, 2014/08/26 12:23:51]

This assumes we want to store the credentials on every successful sign-in or
re-auth. (Right now we only store them after unlock!)
If we really only want to store on re-auth (as written on the bug), then the
test should be "AreEmailsSame(..) && source == SOURCE_REAUTH".

[Roger Tawa OOO till Jul 10th, 2014/08/26 15:29:57]

We already store a hash on first time sign-in, see:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/sig...

Should change the if at line chrome_signin_client.cc:211 to be
IsNewProfileManagement() though.  Can you do that please as part of this CL?

For the code here, yes I think you should add "&& source == SOURCE_REAUTH".  I
think we should add a check for IsNewProfileManagement() as well.

For the primary check, it might be easier to change this to:

   bool is_primary_account = email ==
       SigninManagerFactory::GetForProfile(profile_)->
           GetAuthenticatedAccountId();

but I'm fine if you leave it as is.  I'll be changing it soon anyway as part of
the migration away from email and to gaia ids as account ids.

+    chrome::SetLocalAuthCredentials(profile_, password_);
+
   if (source == signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT ||
       source == signin::SOURCE_REAUTH) {
     ProfileOAuth2TokenServiceFactory::GetForProfile(profile_)->