Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 508433003: vpx: Simplify intrinsic gypi files. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
CC:
chromium-reviews, wwcv, jzern, fgalligan1
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Project:
chromium
Visibility:
Public.

Description

vpx: Simplify intrinsic gypi files. 1.) cflags is only used on non-iOS non-Mac posix, xcode_settings only on Mac and iOS. So use these without conditionals. 2.) Don't remove -mfpu=vfpv3-d16 from cflags. It shouldn't be in there for x86 targets in the first place. No intended behavior change. BUG=none r291620

Patch Set 1 #

Patch Set 2 : vpx: Simplify intrinsic gypi files. #

Patch Set 3 : gen #

Patch Set 4 : cond #

Patch Set 5 : msvstoo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -117 lines) Patch
M generate_gypi.sh View 1 2 3 4 1 chunk +10 lines, -18 lines 0 comments Download
M libvpx_srcs_arm_neon_cpu_detect_intrinsics.gypi View 1 2 3 1 chunk +3 lines, -11 lines 0 comments Download
M libvpx_srcs_x86_64_intrinsics.gypi View 1 2 3 4 chunks +8 lines, -44 lines 0 comments Download
M libvpx_srcs_x86_intrinsics.gypi View 2 3 4 chunks +8 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
thakis@chromium.org changed reviewers: + fgalligan@chromium.org, johannkoenig@chromium.org
6 years, 3 months ago (2014-08-25 22:33:23 UTC) #1
Nico
6 years, 3 months ago (2014-08-25 22:33:23 UTC) #2
Tom Finegan
On 2014/08/25 22:33:23, Nico (hiding) wrote: lgtm
6 years, 3 months ago (2014-08-26 00:01:12 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 3 months ago (2014-08-26 00:02:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/508433003/80001
6 years, 3 months ago (2014-08-26 00:04:01 UTC) #5
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 3 months ago (2014-08-26 00:08:23 UTC) #6
Nico
6 years, 3 months ago (2014-08-26 00:27:05 UTC) #7
Landed manually in r291620


On Mon, Aug 25, 2014 at 5:04 PM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/thakis@
> chromium.org/508433003/80001
>
>
> https://codereview.chromium.org/508433003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698