content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | content/browser/service_worker/service_worker_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index b0c4699523d9b454fb44f993ac17fc25b5d66eed..40a2e8d1aa52057c221e1da79b44f1a430cba8bf 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -105,12 +105,12 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

1L,

helper_->context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(

- registration_, 1L, helper_->context()->AsWeakPtr());

+ registration_.get(), 1L, helper_->context()->AsWeakPtr());

scoped_ptr<ServiceWorkerProviderHost> provider_host(

new ServiceWorkerProviderHost(

kProcessID, kProviderID, helper_->context()->AsWeakPtr(), NULL));

- provider_host->AssociateRegistration(registration_);

+ provider_host->AssociateRegistration(registration_.get());

registration_->SetActiveVersion(version_.get());

ChromeBlobStorageContext* chrome_blob_storage_context =

@@ -219,7 +219,7 @@ TEST_F(ServiceWorkerURLRequestJobTest, BlobResponse) {

expected_response += kTestData;

}

scoped_ptr<storage::BlobDataHandle> blob_handle =

- blob_storage_context->context()->AddFinishedBlob(blob_data_);

+ blob_storage_context->context()->AddFinishedBlob(blob_data_.get());

SetUpWithHelper(new BlobResponder(kProcessID, blob_handle->uuid()));

version_->SetStatus(ServiceWorkerVersion::ACTIVATED);