Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: content/browser/service_worker/service_worker_registration_handle.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration_handle.cc
diff --git a/content/browser/service_worker/service_worker_registration_handle.cc b/content/browser/service_worker/service_worker_registration_handle.cc
index b4b06ef32c1614109b93d18fc02ce57c39983590..b32f5a92b9fe3f3a70bbc72674c686eb612632dd 100644
--- a/content/browser/service_worker/service_worker_registration_handle.cc
+++ b/content/browser/service_worker/service_worker_registration_handle.cc
@@ -25,7 +25,7 @@ ServiceWorkerRegistrationHandle::ServiceWorkerRegistrationHandle(
: kInvalidServiceWorkerRegistrationHandleId),
ref_count_(1),
registration_(registration) {
- DCHECK(registration_);
+ DCHECK(registration_.get());
SetVersionAttributes(registration->installing_version(),
registration->waiting_version(),
registration->active_version());
@@ -33,7 +33,7 @@ ServiceWorkerRegistrationHandle::ServiceWorkerRegistrationHandle(
}
ServiceWorkerRegistrationHandle::~ServiceWorkerRegistrationHandle() {
- DCHECK(registration_);
+ DCHECK(registration_.get());
registration_->RemoveListener(this);
}
@@ -77,15 +77,15 @@ void ServiceWorkerRegistrationHandle::SetVersionAttributes(
ServiceWorkerVersion* active_version) {
ChangedVersionAttributesMask mask;
- if (installing_version != installing_version_) {
+ if (installing_version != installing_version_.get()) {
installing_version_ = installing_version;
mask.add(ChangedVersionAttributesMask::INSTALLING_VERSION);
}
- if (waiting_version != waiting_version_) {
+ if (waiting_version != waiting_version_.get()) {
waiting_version_ = waiting_version;
mask.add(ChangedVersionAttributesMask::WAITING_VERSION);
}
- if (active_version != active_version_) {
+ if (active_version != active_version_.get()) {
active_version_ = active_version;
mask.add(ChangedVersionAttributesMask::ACTIVE_VERSION);
}

Powered by Google App Engine
This is Rietveld 408576698