content/browser/service_worker/service_worker_read_from_cache_job.cc - Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_read_from_cache_job.cc

diff --git a/content/browser/service_worker/service_worker_read_from_cache_job.cc b/content/browser/service_worker/service_worker_read_from_cache_job.cc

index c0dbc82ad5900710255b7adce0e036f4133f49e5..fab8d802a4a4d0cdc0e6f4d1703ea0acdf2bff91 100644

--- a/content/browser/service_worker/service_worker_read_from_cache_job.cc

+++ b/content/browser/service_worker/service_worker_read_from_cache_job.cc

@@ -47,7 +47,7 @@ void ServiceWorkerReadFromCacheJob::Start() {

reader_ = context_->storage()->CreateResponseReader(response_id_);

http_info_io_buffer_ = new HttpResponseInfoIOBuffer;

reader_->ReadInfo(

- http_info_io_buffer_,

+ http_info_io_buffer_.get(),

base::Bind(&ServiceWorkerReadFromCacheJob::OnReadInfoComplete,

weak_factory_.GetWeakPtr()));

SetStatus(net::URLRequestStatus(net::URLRequestStatus::IO_PENDING, 0));