content/browser/service_worker/service_worker_process_manager.cc - Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_process_manager.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | content/browser/service_worker/service_worker_provider_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_process_manager.cc

diff --git a/content/browser/service_worker/service_worker_process_manager.cc b/content/browser/service_worker/service_worker_process_manager.cc

index 7395e7b7b7768675ed4d9225df4436e6a6ba5917..ab6012ad97d3e74a38fbd90ad27c68eabdcd8d3e 100644

--- a/content/browser/service_worker/service_worker_process_manager.cc

+++ b/content/browser/service_worker/service_worker_process_manager.cc

@@ -164,7 +164,7 @@ void ServiceWorkerProcessManager::ReleaseWorkerProcess(int embedded_worker_id) {

instance_info_.find(embedded_worker_id);

DCHECK(info != instance_info_.end());

RenderProcessHost* rph = NULL;

- if (info->second.site_instance) {

+ if (info->second.site_instance.get()) {

rph = info->second.site_instance->GetProcess();

DCHECK_EQ(info->second.process_id, rph->GetID())

<< "A SiteInstance's process shouldn't get destroyed while we're "