content/browser/service_worker/service_worker_handle_unittest.cc - Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_handle_unittest.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_handle.cc ('k') | content/browser/service_worker/service_worker_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_handle_unittest.cc

diff --git a/content/browser/service_worker/service_worker_handle_unittest.cc b/content/browser/service_worker/service_worker_handle_unittest.cc

index 8e4edd32ddbc748ef5c9fa712000966d20b60c00..ecd5dfa1c96e2d7883eac60d9cdd63779916fa6b 100644

--- a/content/browser/service_worker/service_worker_handle_unittest.cc

+++ b/content/browser/service_worker/service_worker_handle_unittest.cc

@@ -52,7 +52,7 @@ class ServiceWorkerHandleTest : public testing::Test {

1L,

helper_->context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(

- registration_, 1L, helper_->context()->AsWeakPtr());

+ registration_.get(), 1L, helper_->context()->AsWeakPtr());

// Simulate adding one process to the worker.

int embedded_worker_id = version_->embedded_worker()->embedded_worker_id();

@@ -82,7 +82,7 @@ TEST_F(ServiceWorkerHandleTest, OnVersionStateChanged) {

helper_.get(),

1 /* thread_id */,

33 /* provider_id */,

- version_);

+ version_.get());

// Start the worker, and then...

ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;