Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc b/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
index 552cbfaa2f041ece1c653ac05ba4de60a1f831d9..cbce78a517871f39bd647490a6b3f6ed9d2be0ca 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
+++ b/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
@@ -44,8 +44,7 @@ class ServiceWorkerControlleeRequestHandlerTest : public testing::Test {
registration_ = new ServiceWorkerRegistration(
scope_, script_url_, 1L, context()->AsWeakPtr());
version_ = new ServiceWorkerVersion(
- registration_,
- 1L, context()->AsWeakPtr());
+ registration_.get(), 1L, context()->AsWeakPtr());
// An empty host.
scoped_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(
@@ -81,9 +80,10 @@ class ServiceWorkerControlleeRequestHandlerTest : public testing::Test {
TEST_F(ServiceWorkerControlleeRequestHandlerTest, ActivateWaitingVersion) {
// Store a registration that is installed but not activated yet.
version_->SetStatus(ServiceWorkerVersion::INSTALLED);
- registration_->SetWaitingVersion(version_);
+ registration_->SetWaitingVersion(version_.get());
context()->storage()->StoreRegistration(
- registration_, version_,
+ registration_.get(),
+ version_.get(),
base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
base::RunLoop().RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698