content/browser/service_worker/service_worker_context_request_handler.cc - Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.cc ('k') | content/browser/service_worker/service_worker_context_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler.cc b/content/browser/service_worker/service_worker_context_request_handler.cc

index 462d3a88bd5a33458b1a32ed672ca6546c00e901..c30598539d4ddeba4a460e11b92a3c7d62cf15e4 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler.cc

@@ -34,7 +34,7 @@ ServiceWorkerContextRequestHandler::~ServiceWorkerContextRequestHandler() {

net::URLRequestJob* ServiceWorkerContextRequestHandler::MaybeCreateJob(

net::URLRequest* request,

net::NetworkDelegate* network_delegate) {

- if (!provider_host_ || !version_ || !context_)

+ if (!provider_host_ || !version_.get() || !context_)

return NULL;

// We currently have no use case for hijacking a redirected request.

@@ -72,7 +72,7 @@ net::URLRequestJob* ServiceWorkerContextRequestHandler::MaybeCreateJob(

network_delegate,

resource_type_,

context_,

- version_,

+ version_.get(),

extra_load_flags,

response_id);

}