Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 508433002: Remove implicit conversions from scoped_refptr to T* in content/browser/service_worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 1e8450cf012bd5d79a20c95a0db861f80715ab29..b7515730582a00234f2791e4790f4beb52c2011b 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -498,7 +498,7 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
wrapper()->context()->storage()->NewRegistrationId(),
wrapper()->context()->AsWeakPtr());
version_ = new ServiceWorkerVersion(
- registration_,
+ registration_.get(),
wrapper()->context()->storage()->NewVersionId(),
wrapper()->context()->AsWeakPtr());
AssociateRendererProcessToWorker(version_->embedded_worker());
@@ -536,13 +536,14 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
false);
version_->SetStatus(ServiceWorkerVersion::ACTIVATED);
version_->DispatchFetchEvent(
- request, CreateResponseReceiver(BrowserThread::UI, done,
- blob_context_, result));
+ request,
+ CreateResponseReceiver(
+ BrowserThread::UI, done, blob_context_.get(), result));
}
void StopOnIOThread(const base::Closure& done,
ServiceWorkerStatusCode* result) {
- ASSERT_TRUE(version_);
+ ASSERT_TRUE(version_.get());
version_->StopWorker(CreateReceiver(BrowserThread::UI, done, result));
}
@@ -841,7 +842,7 @@ class ServiceWorkerBlackBoxBrowserTest : public ServiceWorkerBrowserTest {
ServiceWorkerStatusCode status,
const scoped_refptr<ServiceWorkerRegistration>& registration) {
*out_status = status;
- if (registration) {
+ if (registration.get()) {
*script_url = registration->script_url();
} else {
EXPECT_NE(SERVICE_WORKER_OK, status);

Powered by Google App Engine
This is Rietveld 408576698