Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 508393002: Adding more checking and some debugging information in Custom Font Collection. (Closed)

Created:
6 years, 3 months ago by Shrikant Kelkar
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding more checking and some debugging information in Custom Font Collection. +rsesek for crash key/value OWNERS. R=scottmg,ananta,cpu TBR=rsesek@chromium.org BUG=399233 Committed: https://crrev.com/dd5e80b2f8e1cf3c65bf063fd1e2a319656bfb40 Cr-Commit-Position: refs/heads/master@{#292292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/common/crash_keys.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_font_platform_win.cc View 6 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Shrikant Kelkar
shrikant@chromium.org changed reviewers: + rsesek@chromium.org
6 years, 3 months ago (2014-08-28 00:13:31 UTC) #1
Shrikant Kelkar
ptal.
6 years, 3 months ago (2014-08-28 00:14:16 UTC) #2
ananta
lgtm
6 years, 3 months ago (2014-08-28 00:32:38 UTC) #3
scottmg
lgtm
6 years, 3 months ago (2014-08-28 00:33:20 UTC) #4
Shrikant Kelkar
shrikant@chromium.org changed reviewers: - rsesek@chromium.org
6 years, 3 months ago (2014-08-28 00:35:15 UTC) #5
Shrikant Kelkar
The CQ bit was checked by shrikant@chromium.org
6 years, 3 months ago (2014-08-28 00:35:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/508393002/1
6 years, 3 months ago (2014-08-28 00:37:41 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:36:59 UTC) #8
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:37:00 UTC) #9
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 3 months ago (2014-08-28 01:42:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/508393002/1
6 years, 3 months ago (2014-08-28 01:44:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:45:54 UTC) #12
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:45:55 UTC) #13
Shrikant Kelkar
The CQ bit was checked by shrikant@chromium.org
6 years, 3 months ago (2014-08-28 02:06:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/508393002/1
6 years, 3 months ago (2014-08-28 02:06:53 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as 24bed708036a6826aa110751be899370b042487a
6 years, 3 months ago (2014-08-28 02:08:13 UTC) #16
Robert Sesek
rsesek@chromium.org changed reviewers: + rsesek@chromium.org
6 years, 3 months ago (2014-08-28 13:25:36 UTC) #17
Robert Sesek
lgtm
6 years, 3 months ago (2014-08-28 13:25:36 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:26 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dd5e80b2f8e1cf3c65bf063fd1e2a319656bfb40
Cr-Commit-Position: refs/heads/master@{#292292}

Powered by Google App Engine
This is Rietveld 408576698